From xaa@xaa.stack.nl  Sat Feb 15 16:46:55 1997
Return-Path: <xaa@xaa.stack.nl>
Received: from terra.stack.nl (terra.stack.nl [131.155.140.128])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA29482
          for <audit-games@freebsd.org>; Sat, 15 Feb 1997 16:46:54 -0800 (PST)
Received: from xaa.stack.nl (uucp@localhost) by terra.stack.nl (8.8.5) with UUCP id BAA27248 for audit-games@freebsd.org; Sun, 16 Feb 1997 01:46:50 +0100 (MET)
Received: (from xaa@localhost) by xaa.stack.nl (8.8.5/8.8.2) id BAA15206; Sun, 16 Feb 1997 01:43:50 +0100 (MET)
Message-ID: <19970216014350.GY41671@xaa.stack.nl>
Date: Sun, 16 Feb 1997 01:43:50 +0100
From: xaa@stack.nl (Mark Huizer)
To: audit-games@freebsd.org
Subject: does this alias exist??
X-Mailer: Mutt 0.60
Mime-Version: 1.0
Reply-To: xaa@stack.nl (Mark Huizer)

Well, just testing if three ppl are on here, as it should be
(xaa,ab,ee)...

If so, Eivind will be the committer I suppose?

Greetings,

Mark
-------------------------------------------------------------------------
- Mark Huizer  - xaa@stack.nl     - rcbamh@urc.tue.nl                   -
-------------------------------------------------------------------------
- Always borrow money from a pessimist; he doesn't expect to be		-
- paid back.								-
-------------------------------------------------------------------------

From aaronb@j51.com  Sat Feb 15 18:26:23 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA06631
          for <audit-games@freebsd.org>; Sat, 15 Feb 1997 18:26:19 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id VAA06916; Sat, 15 Feb 1997 21:26:28 -0500 (EST)
Date: Sat, 15 Feb 1997 21:26:28 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: audit-games@freebsd.org
Subject: Re: does this alias exist??
In-Reply-To: <19970216014350.GY41671@xaa.stack.nl>
Message-ID: <Pine.BSF.3.91.970215203837.5404A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII



On Sun, 16 Feb 1997, Mark Huizer wrote:

> Well, just testing if three ppl are on here, as it should be
> (xaa,ab,ee)...
> 
	Ok, let's recap for ee.  I've found a few bugs, Mark's written a 
couple of patches.  I'm in the process of writing patches at the 
moment... here's a preliminary patch for battlestar.  There's three bugs 
here, two overflows and a race condition.  I'm not sure if I handled the 
race condition in the most elegant manner, comments appreciated.

--- battlestar/externs.h.old    Sat Feb 15 21:08:20 1997
+++ battlestar/externs.h        Sat Feb 15 21:06:43 1997
@@ -248,11 +248,11 @@
 char *getcom(), *getword();
 
        /* state of the game */
-int time;
+int gtime;
 int position;
 int direction;
 int left, right, ahead, back;
-int clock, fuel, torps;
+int gclock, fuel, torps;
 int carrying, encumber;
 int rythmn;
 int followfight;

--- battlestar/save.c.old       Sat Feb 15 16:50:39 1997
+++ battlestar/save.c   Sat Feb 15 21:07:19 1997
@@ -35,27 +35,33 @@
 static char sccsid[] = "@(#)save.c     8.1 (Berkeley) 5/31/93";
 #endif /* not lint */
 
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/param.h>                 /* MAXPATHLEN */
+#include <fcntl.h>
 #include "externs.h"
 
+void
 restore()
 {
        char *getenv();
        char *home;
-       char home1[100];
+       char home1[MAXPATHLEN];
        register int n;
        int tmp;
        register FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");
+       if ( (home = getenv("HOME")) != NULL) 
+         sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
+       else return;
+
        if ((fp = fopen(home1, "r")) == 0) {
                perror(home1);
                return;
        }
        fread(&WEIGHT, sizeof WEIGHT, 1, fp);
        fread(&CUMBER, sizeof CUMBER, 1, fp);
-       fread(&clock, sizeof clock, 1, fp);
+       fread(&gclock, sizeof gclock, 1, fp);
        fread(&tmp, sizeof tmp, 1, fp);
        location = tmp ? dayfile : nightfile;
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -68,7 +74,7 @@
        fread(notes, sizeof notes, 1, fp);
        fread(&direction, sizeof direction, 1, fp);
        fread(&position, sizeof position, 1, fp);
-       fread(&time, sizeof time, 1, fp);
+       fread(&gtime, sizeof gtime, 1, fp);
        fread(&fuel, sizeof fuel, 1, fp);
        fread(&torps, sizeof torps, 1, fp);
        fread(&carrying, sizeof carrying, 1, fp);
@@ -90,26 +96,51 @@
        fread(&ego, sizeof ego, 1, fp);
 }
 
+void
 save()
 {
+       struct stat sbuf;
        char *getenv();
        char *home;
-       char home1[100];
+       char home1[MAXPATHLEN];
        register int n;
-       int tmp;
+       int tmp, fd;
        FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");
-       if ((fp = fopen(home1, "w")) == 0) {
+       if ( (home = getenv("HOME")) != NULL) 
+               sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
+       else 
+               return;
+
+       /* Try to open the file safely. */
+       if ( (stat(home1, &sbuf)) < 0) {                
+               fd = open(home1, O_WRONLY|O_CREAT|O_EXCL);
+               if (fd < 0) {
+                       fprintf(stderr, "Can't create %s\n", home1);
+                       return;
+               }
+       } else {
+               if (sbuf.st_nlink > 1) {
+                       fprintf(stderr, "No symlinks!\n");
+                       return;
+               }
+
+               fd = open(home1, O_WRONLY|O_EXCL);
+               if (fd < 0) {
+                       fprintf(stderr, "Can't open %s for writing\n", home1);
+                       return;
+               }
+       }
+
+       if ((fp = fdopen(fd, "w")) == 0) {
                perror(home1);
                return;
        }
+
        printf("Saved in %s.\n", home1);
        fwrite(&WEIGHT, sizeof WEIGHT, 1, fp);
        fwrite(&CUMBER, sizeof CUMBER, 1, fp);
-       fwrite(&clock, sizeof clock, 1, fp);
+       fwrite(&gclock, sizeof gclock, 1, fp);
        tmp = location == dayfile;
        fwrite(&tmp, sizeof tmp, 1, fp);
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -122,7 +153,7 @@
        fwrite(notes, sizeof notes, 1, fp);
        fwrite(&direction, sizeof direction, 1, fp);
        fwrite(&position, sizeof position, 1, fp);
-       fwrite(&time, sizeof time, 1, fp);
+       fwrite(&gtime, sizeof gtime, 1, fp);
        fwrite(&fuel, sizeof fuel, 1, fp);
        fwrite(&torps, sizeof torps, 1, fp);
        fwrite(&carrying, sizeof carrying, 1, fp);
@@ -142,4 +173,5 @@
        fwrite(&pleasure, sizeof pleasure, 1, fp);
        fwrite(&power, sizeof power, 1, fp);
        fwrite(&ego, sizeof ego, 1, fp);
+
 }






From xaa@xaa.stack.nl  Sat Feb 15 18:33:31 1997
Return-Path: <xaa@xaa.stack.nl>
Received: from terra.stack.nl (terra.stack.nl [131.155.140.128])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA06771
          for <audit-games@freebsd.org>; Sat, 15 Feb 1997 18:33:30 -0800 (PST)
Received: from xaa.stack.nl (uucp@localhost) by terra.stack.nl (8.8.5) with UUCP id DAA00618; Sun, 16 Feb 1997 03:33:25 +0100 (MET)
Received: (from xaa@localhost) by xaa.stack.nl (8.8.5/8.8.2) id DAA23564; Sun, 16 Feb 1997 03:33:12 +0100 (MET)
Message-ID: <19970216033312.EA00561@xaa.stack.nl>
Date: Sun, 16 Feb 1997 03:33:12 +0100
From: xaa@stack.nl (Mark Huizer)
To: aaronb@j51.com (Aaron Bornstein)
Cc: audit-games@freebsd.org
Subject: Re: does this alias exist??
References: <19970216014350.GY41671@xaa.stack.nl> <Pine.BSF.3.91.970215203837.5404A-100000@j51.com>
X-Mailer: Mutt 0.60
Mime-Version: 1.0
Reply-To: xaa@stack.nl (Mark Huizer)
In-Reply-To: <Pine.BSF.3.91.970215203837.5404A-100000@j51.com>; from "Aaron Bornstein" on Feb 15, 1997 21:26:28 -0500

> 	Ok, let's recap for ee.  I've found a few bugs, Mark's written a 
> couple of patches.  I'm in the process of writing patches at the 
> moment... here's a preliminary patch for battlestar.  There's three bugs 
> here, two overflows and a race condition.  I'm not sure if I handled the 
> race condition in the most elegant manner, comments appreciated.
> 
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <sys/param.h>                 /* MAXPATHLEN */
> +#include <fcntl.h>
>  #include "externs.h"
>  

To make this compile again without too many warnings, I changed setbit
to set_bit in all the files and here.

and in externs.h, change the definition of uname to:

char uname[MAXLOGNAME];

FreeBSD-current has 16 byte login names.

If you complete your patches, I'll compare them to my patches :-)

Greetings,
Mark
-------------------------------------------------------------------------
- Mark Huizer  - xaa@stack.nl     - rcbamh@urc.tue.nl                   -
-------------------------------------------------------------------------
- Q: How many surrealists does it take to screw in a lightbulb?		-
- A: Two.  One to hold the giraffe and the other to fill the		-
-    bathtub with brightly colored machine tools.			-
-------------------------------------------------------------------------

From aaronb@j51.com  Sat Feb 15 18:49:34 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA07279
          for <audit-games@freebsd.org>; Sat, 15 Feb 1997 18:49:33 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id VAA11005; Sat, 15 Feb 1997 21:49:41 -0500 (EST)
Date: Sat, 15 Feb 1997 21:49:41 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: Mark Huizer <xaa@stack.nl>
cc: audit-games@freebsd.org
Subject: Re: does this alias exist??
In-Reply-To: <19970216033312.EA00561@xaa.stack.nl>
Message-ID: <Pine.BSF.3.91.970215214840.7184A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII



On Sun, 16 Feb 1997, Mark Huizer wrote:

> 
> If you complete your patches, I'll compare them to my patches :-)
> 
	Had a bunch of compile problems, so instead of making patches for 
every single module, I just fixed it and tarred up the damn tree :) 
It's available from http://www.j51.com/~aaronb/battlestar.tar.

					--Aaron


From xaa@xaa.stack.nl  Sun Feb 16 02:45:02 1997
Return-Path: <xaa@xaa.stack.nl>
Received: from terra.stack.nl (terra.stack.nl [131.155.140.128])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA23753
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 02:45:01 -0800 (PST)
Received: from xaa.stack.nl (uucp@localhost) by terra.stack.nl (8.8.5) with UUCP id LAA05122; Sun, 16 Feb 1997 11:44:55 +0100 (MET)
Received: (from xaa@localhost) by xaa.stack.nl (8.8.5/8.8.2) id LAA01380; Sun, 16 Feb 1997 11:44:26 +0100 (MET)
Message-ID: <19970216114426.XV27581@xaa.stack.nl>
Date: Sun, 16 Feb 1997 11:44:26 +0100
From: xaa@stack.nl (Mark Huizer)
To: aaronb@j51.com (Aaron Bornstein)
Cc: audit-games@freebsd.org
Subject: Re: does this alias exist??
References: <19970216033312.EA00561@xaa.stack.nl> <Pine.BSF.3.91.970215214840.7184A-100000@j51.com>
X-Mailer: Mutt 0.60
Mime-Version: 1.0
Reply-To: xaa@stack.nl (Mark Huizer)
In-Reply-To: <Pine.BSF.3.91.970215214840.7184A-100000@j51.com>; from "Aaron Bornstein" on Feb 15, 1997 21:49:41 -0500

> > If you complete your patches, I'll compare them to my patches :-)
> > 
> 	Had a bunch of compile problems, so instead of making patches for 
> every single module, I just fixed it and tarred up the damn tree :) 
> It's available from http://www.j51.com/~aaronb/battlestar.tar.
> 
Well, I made a diff, which I put at
ftp://cvsup.nl.freebsd.org/pub/FreeBSD/.audit/battlestar.diff

So if ee wants to check, review, commit, let him go ahead :-)

Oh yeah, you had everything I patched to, but I removed one thing you
changed:
I see you changed time and clock to gtime and gclock (in order to
prevents collisions with time() and clock() ??), but well, changing it
in globals.c was a bit overkill :-) it was just a poor little room
description, that couldn't help it. The same goes for words.c, where you
changed the commands time and timer.

And of course I don't get the sprintf construct in save.c, but well, if
you think it does what it should... you're welcome :-)

Mark

-------------------------------------------------------------------------
- Mark Huizer  - xaa@stack.nl     - rcbamh@urc.tue.nl                   -
-------------------------------------------------------------------------
- Every man has one thing he can do better than anyone else;		-
- usually it is reading his own handwriting (G.Norman Collie)		-
-------------------------------------------------------------------------

From xaa@xaa.stack.nl  Sun Feb 16 03:13:43 1997
Return-Path: <xaa@xaa.stack.nl>
Received: from terra.stack.nl (terra.stack.nl [131.155.140.128])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA24908
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 03:13:41 -0800 (PST)
Received: from xaa.stack.nl (uucp@localhost) by terra.stack.nl (8.8.5) with UUCP id MAA05527 for audit-games@freebsd.org; Sun, 16 Feb 1997 12:13:38 +0100 (MET)
Received: (from xaa@localhost) by xaa.stack.nl (8.8.5/8.8.2) id MAA02553; Sun, 16 Feb 1997 12:13:21 +0100 (MET)
Message-ID: <19970216121321.YK55308@xaa.stack.nl>
Date: Sun, 16 Feb 1997 12:13:21 +0100
From: xaa@stack.nl (Mark Huizer)
To: audit-games@freebsd.org
Subject: patches for cribbage
X-Mailer: Mutt 0.60
Mime-Version: 1.0
Reply-To: xaa@stack.nl (Mark Huizer)

Well... all I could come up with (I suppose Aaron will at least double
them :-)

--- instr.c.orig	Sat Feb 15 22:11:37 1997
+++ instr.c	Sun Feb 16 02:34:49 1997
@@ -74,6 +74,7 @@
 		if (pager = rindex(path, '/'))
 			++pager;
 		pager = path;
+		setuid(getuid());
 		execlp(path, pager, _PATH_INSTR, (char *)NULL);
 		(void)fprintf(stderr, "cribbage: %s.\n", strerror(errno));
 		_exit(1);

Mark
-------------------------------------------------------------------------
- Mark Huizer  - xaa@stack.nl     - rcbamh@urc.tue.nl                   -
-------------------------------------------------------------------------
- If you can smile when things go wrong, you have someone in 		-
- mind to blame								-
-------------------------------------------------------------------------

From aaronb@j51.com  Sun Feb 16 06:43:18 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA06962
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 06:43:18 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id JAA03436; Sun, 16 Feb 1997 09:43:28 -0500 (EST)
Date: Sun, 16 Feb 1997 09:43:28 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: Mark Huizer <xaa@stack.nl>
cc: audit-games@freebsd.org
Subject: Re: does this alias exist??
In-Reply-To: <19970216114426.XV27581@xaa.stack.nl>
Message-ID: <Pine.BSF.3.91.970216094007.3304A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII



On Sun, 16 Feb 1997, Mark Huizer wrote:
> I see you changed time and clock to gtime and gclock (in order to
> prevents collisions with time() and clock() ??), but well, changing it
> in globals.c was a bit overkill :-) it was just a poor little room
> description, that couldn't help it. The same goes for words.c, where you
> changed the commands time and timer.
> 
	Heh, woops, I just ran the source through a sed script, then 
compiled and fixed all the errors. :)

> And of course I don't get the sprintf construct in save.c, but well, if
> you think it does what it should... you're welcome :-)
> 
> Mark
> 
	What don't you get about it?

        if ( (home = getenv("HOME")) != NULL) 
                sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);

	That copies home and the string "/Bstar" into home1, limiting 
home to MAXPATHLEN - 7 characters (six for "/Bstar" and one terminating 
NULL, which sprintf() adds.)

						-- Aaron


From aaronb@j51.com  Sun Feb 16 07:14:29 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA07946
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 07:14:28 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id KAA04438; Sun, 16 Feb 1997 10:14:39 -0500 (EST)
Date: Sun, 16 Feb 1997 10:14:39 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: audit-games@freebsd.org
Subject: sail patch
Message-ID: <Pine.BSF.3.91.970216101313.4361A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII



gets()!@
GETS()!@

--- sail/pl_main.c.orig Sun Feb 16 10:11:03 1997
+++ sail/pl_main.c      Sun Feb 16 10:04:16 1997
@@ -198,7 +198,7 @@
        else {
                (void) printf("Your name, Captain? ");
                (void) fflush(stdout);
-               (void) gets(captain);
+               (void) fgets(captain, sizeof(captain), stdin);
                if (!*captain)
                        (void) strcpy(captain, "no name");
        }
@@ -210,7 +210,7 @@
                printf("\nInitial broadside %s (grape, chain, round, double): ",
                        n ? "right" : "left");
                (void) fflush(stdout);
-               (void) scanf("%s", buf);
+               (void) fgets(buf, sizeof(buf), stdin);
                switch (*buf) {
                case 'g':
                        load = L_GRAPE;


From eivind@dimaga.com  Sun Feb 16 10:29:48 1997
Return-Path: <eivind@dimaga.com>
Received: from agora.rdrop.com (root@agora.rdrop.com [199.2.210.241])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id KAA18021
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 10:29:47 -0800 (PST)
Received: from nic.follonett.no by agora.rdrop.com with smtp
	(Smail3.1.29.1 #17) id m0vwBJZ-0008zUC; Sun, 16 Feb 97 10:27 PST
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id TAA08460; Sun, 16 Feb 1997 19:00:23 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.7.5/8.7.2) with SMTP id TAA09490; Sun, 16 Feb 1997 19:02:32 +0100 (MET)
Message-Id: <3.0.32.19970216190232.00a39a80@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Sun, 16 Feb 1997 19:02:33 +0100
To: xaa@stack.nl (Mark Huizer)
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: does this alias exist??
Cc: aaronb@j51.com (Aaron Bornstein), audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 11:44 AM 2/16/97 +0100, Mark Huizer wrote:
>> > If you complete your patches, I'll compare them to my patches :-)
>> > 
>> 	Had a bunch of compile problems, so instead of making patches for 
>> every single module, I just fixed it and tarred up the damn tree :) 
>> It's available from http://www.j51.com/~aaronb/battlestar.tar.
>> 
>Well, I made a diff, which I put at
>ftp://cvsup.nl.freebsd.org/pub/FreeBSD/.audit/battlestar.diff
>
>So if ee wants to check, review, commit, let him go ahead :-)

I'm doing it right now.  Rather, I tried to do it right now - that diff
file is empty.  Could you come up with another 

>And of course I don't get the sprintf construct in save.c, but well, if
>you think it does what it should... you're welcome :-)

It's correct.  It is uses * to get a field-width limitation instead of
using snprintf, which make it more portable but also less readable.

Do people want me to pick send back reports of the style-nits I've picked
from the patches, or just fix'n'commit?



Eivind Eklund  perhaps@yes.no  http://maybe.yes.no/perhaps/
eivind@freebsd.org


From xaa@xaa.stack.nl  Sun Feb 16 10:48:03 1997
Return-Path: <xaa@xaa.stack.nl>
Received: from terra.stack.nl (terra.stack.nl [131.155.140.128])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA19201
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 10:48:01 -0800 (PST)
Received: from xaa.stack.nl (uucp@localhost) by terra.stack.nl (8.8.5) with UUCP id TAA10397 for audit-games@freebsd.org; Sun, 16 Feb 1997 19:47:56 +0100 (MET)
Received: (from xaa@localhost) by xaa.stack.nl (8.8.5/8.8.2) id TAA01041; Sun, 16 Feb 1997 19:45:31 +0100 (MET)
Message-ID: <19970216194530.SC40136@xaa.stack.nl>
Date: Sun, 16 Feb 1997 19:45:30 +0100
From: xaa@stack.nl (Mark Huizer)
To: audit-games@freebsd.org
Subject: Re: does this alias exist??
References: <3.0.32.19970216190232.00a39a80@dimaga.com>
X-Mailer: Mutt 0.60
Mime-Version: 1.0
Reply-To: xaa@stack.nl (Mark Huizer)
In-Reply-To: <3.0.32.19970216190232.00a39a80@dimaga.com>; from "Eivind Eklund" on Feb 16, 1997 19:02:33 +0100

> >So if ee wants to check, review, commit, let him go ahead :-)
> 
> I'm doing it right now.  Rather, I tried to do it right now - that diff
> file is empty.  Could you come up with another 

Damn... the disk was full when I tried to copy it :-(

Now it's there!

> Do people want me to pick send back reports of the style-nits I've picked
> from the patches, or just fix'n'commit?
> 
What do you prefer?

Mark
-------------------------------------------------------------------------
- Mark Huizer  - xaa@stack.nl     - rcbamh@urc.tue.nl                   -
-------------------------------------------------------------------------
- What's the use of a good quotation if you can't change it?		-
-------------------------------------------------------------------------

From aaronb@j51.com  Sun Feb 16 10:55:34 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA19637
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 10:55:33 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id NAA15806; Sun, 16 Feb 1997 13:55:26 -0500 (EST)
Date: Sun, 16 Feb 1997 13:55:26 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: Eivind Eklund <eivind@dimaga.com>
cc: Mark Huizer <xaa@stack.nl>, audit-games@freebsd.org
Subject: Re: does this alias exist??
In-Reply-To: <3.0.32.19970216190232.00a39a80@dimaga.com>
Message-ID: <Pine.BSF.3.91.970216135453.15766A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Sun, 16 Feb 1997, Eivind Eklund wrote:

> 
> Do people want me to pick send back reports of the style-nits I've picked
> from the patches, or just fix'n'commit?
> 
	I'd definitely like to see the style nits, could always use 
constructive criticism.

					-- Aaron


From eivind@dimaga.com  Sun Feb 16 13:20:25 1997
Return-Path: <eivind@dimaga.com>
Received: from agora.rdrop.com (root@agora.rdrop.com [199.2.210.241])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id NAA28052
          for <audit-games@freebsd.org>; Sun, 16 Feb 1997 13:20:24 -0800 (PST)
Received: from nic.follonett.no by agora.rdrop.com with smtp
	(Smail3.1.29.1 #17) id m0vwBeZ-0008zYC; Sun, 16 Feb 97 10:49 PST
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id TAA08761; Sun, 16 Feb 1997 19:32:35 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.7.5/8.7.2) with SMTP id TAA09848; Sun, 16 Feb 1997 19:32:54 +0100 (MET)
Message-Id: <3.0.32.19970216193254.00cbc100@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Sun, 16 Feb 1997 19:32:55 +0100
To: xaa@stack.nl (Mark Huizer)
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: does this alias exist??
Cc: audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 01:43 AM 2/16/97 +0100, Mark Huizer wrote:
>Well, just testing if three ppl are on here, as it should be
>(xaa,ab,ee)...
>
>If so, Eivind will be the committer I suppose?

There doesn't seem to be much choice, does it? :)


Eivind Eklund  perhaps@yes.no  http://maybe.yes.no/perhaps/
eivind@freebsd.org


From eivind@dimaga.com  Tue Feb 18 01:29:30 1997
Return-Path: <eivind@dimaga.com>
Received: from nic.follonett.no (nic.follonett.no [194.198.43.10])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id BAA20250
          for <audit-games@freebsd.org>; Tue, 18 Feb 1997 01:29:25 -0800 (PST)
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id KAA07454 for audit-games@freebsd.org; Tue, 18 Feb 1997 10:28:00 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.7.5/8.7.2) with SMTP id KAA16668 for <audit-games@freebsd.org>; Tue, 18 Feb 1997 10:12:20 +0100 (MET)
Message-Id: <3.0.32.19970218101219.00c48640@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Tue, 18 Feb 1997 10:12:20 +0100
To: audit-games@freebsd.org
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: does this alias exist??
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 01:55 PM 2/16/97 -0500, Aaron Bornstein wrote:
>On Sun, 16 Feb 1997, Eivind Eklund wrote:
>
>> 
>> Do people want me to pick send back reports of the style-nits I've picked
>> from the patches, or just fix'n'commit?
>> 
>	I'd definitely like to see the style nits, could always use 
>constructive criticism.

OK, for Battlestar:

1.  I removed the references to KERNEL, as they no longer served any
function after fixing time to gtime.
2.  I undid the change from setbit to set_bit, and instead made the two
different setbit()s compatible.  This required changing from int to char 4
or 5 places, and a change of BITS from 8*sizeof(int) to 8.
3.  Fixed a split string in com5.c
4.  Fixed a split string in com1.c

The following nits were in the original patch:

--- battlestar/save.c.old       Sat Feb 15 16:50:39 1997
+++ battlestar/save.c   Sat Feb 15 21:07:19 1997
@@ -35,27 +35,33 @@
 static char sccsid[] = "@(#)save.c     8.1 (Berkeley) 5/31/93";
 #endif /* not lint */
 
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/param.h>                 /* MAXPATHLEN */
+#include <fcntl.h>
 #include "externs.h"
 
+void
 restore()
 {
        char *getenv();
        char *home;
-       char home1[100];
+       char home1[MAXPATHLEN];
        register int n;
        int tmp;
        register FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");
+       if ( (home = getenv("HOME")) != NULL) 
            ^
+         sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
+       else return;


Extra space.  In addition, this line of code is not in style with the rest
of the sourcefile (the rest don't use NULL).  I rewrote these 3 lines to

+       home = getenv("HOME");
+       if (home == 0)
+         return; 
+       sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);

which follow the style of the source better.


        if ((fp = fopen(home1, "r")) == 0) {
                perror(home1);
                return;
        }
        fread(&WEIGHT, sizeof WEIGHT, 1, fp);
        fread(&CUMBER, sizeof CUMBER, 1, fp);
-       fread(&clock, sizeof clock, 1, fp);
+       fread(&gclock, sizeof gclock, 1, fp);
        fread(&tmp, sizeof tmp, 1, fp);
        location = tmp ? dayfile : nightfile;
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -68,7 +74,7 @@
        fread(notes, sizeof notes, 1, fp);
        fread(&direction, sizeof direction, 1, fp);
        fread(&position, sizeof position, 1, fp);
-       fread(&time, sizeof time, 1, fp);
+       fread(&gtime, sizeof gtime, 1, fp);
        fread(&fuel, sizeof fuel, 1, fp);
        fread(&torps, sizeof torps, 1, fp);
        fread(&carrying, sizeof carrying, 1, fp);
@@ -90,26 +96,51 @@
        fread(&ego, sizeof ego, 1, fp);
 }
 
+void
 save()
 {
+       struct stat sbuf;
        char *getenv();
        char *home;
-       char home1[100];
+       char home1[MAXPATHLEN];
        register int n;
-       int tmp;
+       int tmp, fd;
        FILE *fp;
 
-       home = getenv("HOME");
-       strcpy(home1, home);
-       strcat(home1, "/Bstar");
-       if ((fp = fopen(home1, "w")) == 0) {
+       if ( (home = getenv("HOME")) != NULL) 
+               sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
+       else 
+               return;

Same as above.

+       /* Try to open the file safely. */
+       if ( (stat(home1, &sbuf)) < 0) {                
+               fd = open(home1, O_WRONLY|O_CREAT|O_EXCL);
+               if (fd < 0) {
+                       fprintf(stderr, "Can't create %s\n", home1);
+                       return;
+               }
+       } else {
+               if (sbuf.st_nlink > 1) {
+                       fprintf(stderr, "No symlinks!\n");
+                       return;
+               }
+
+               fd = open(home1, O_WRONLY|O_EXCL);
+               if (fd < 0) {
+                       fprintf(stderr, "Can't open %s for writing\n", home1);
+                       return;
+               }
+       }
+
+       if ((fp = fdopen(fd, "w")) == 0) {
                perror(home1);
                return;
        }
+
        printf("Saved in %s.\n", home1);
        fwrite(&WEIGHT, sizeof WEIGHT, 1, fp);
        fwrite(&CUMBER, sizeof CUMBER, 1, fp);
-       fwrite(&clock, sizeof clock, 1, fp);
+       fwrite(&gclock, sizeof gclock, 1, fp);
        tmp = location == dayfile;
        fwrite(&tmp, sizeof tmp, 1, fp);
        for (n = 1; n <= NUMOFROOMS; n++) {
@@ -122,7 +153,7 @@
        fwrite(notes, sizeof notes, 1, fp);
        fwrite(&direction, sizeof direction, 1, fp);
        fwrite(&position, sizeof position, 1, fp);
-       fwrite(&time, sizeof time, 1, fp);
+       fwrite(&gtime, sizeof gtime, 1, fp);
        fwrite(&fuel, sizeof fuel, 1, fp);
        fwrite(&torps, sizeof torps, 1, fp);
        fwrite(&carrying, sizeof carrying, 1, fp);
@@ -142,4 +173,5 @@
        fwrite(&pleasure, sizeof pleasure, 1, fp);
        fwrite(&power, sizeof power, 1, fp);
        fwrite(&ego, sizeof ego, 1, fp);
+

Whitespace-changes is generally considered a bad thing.

 }


If the changes I've done sound OK, can one of your review them before I put
them in the tree?
(Sorry for the delay - thought I'd sent this message days ago.)


Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org

From aaronb@j51.com  Tue Feb 18 10:21:51 1997
Return-Path: <aaronb@j51.com>
Received: from j51.com (root@gorplex.j51.com [199.224.7.51])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA19841
          for <audit-games@freebsd.org>; Tue, 18 Feb 1997 10:21:48 -0800 (PST)
Received: (from aaronb@localhost) by j51.com (8.8.5/8.8.5) id NAA08061; Tue, 18 Feb 1997 13:21:41 -0500 (EST)
Date: Tue, 18 Feb 1997 13:21:40 -0500 (EST)
From: Aaron Bornstein <aaronb@j51.com>
To: Eivind Eklund <eivind@dimaga.com>
cc: audit-games@freebsd.org
Subject: Re: does this alias exist??
In-Reply-To: <3.0.32.19970218101219.00c48640@dimaga.com>
Message-ID: <Pine.BSF.3.91.970218131944.7922A-100000@j51.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII



On Tue, 18 Feb 1997, Eivind Eklund wrote:

> Extra space.  In addition, this line of code is not in style with the rest
> of the sourcefile (the rest don't use NULL).  I rewrote these 3 lines to
> 
> +       home = getenv("HOME");
> +       if (home == 0)
> +         return; 
> +       sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
> 
> which follow the style of the source better.
> 
	Whether or not it follows the style of the source, comparing 
pointers to 0 is Bad Form.


					-- Aaron

From eivind@dimaga.com  Thu Feb 20 00:41:23 1997
Return-Path: <eivind@dimaga.com>
Received: from agora.rdrop.com (root@agora.rdrop.com [199.2.210.241])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id AAA29222
          for <audit-games@freebsd.org>; Thu, 20 Feb 1997 00:41:23 -0800 (PST)
Received: from nic.follonett.no by agora.rdrop.com with smtp
	(Smail3.1.29.1 #17) id m0vxU2o-0008rWC; Thu, 20 Feb 97 00:39 PST
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id EAA07084; Thu, 20 Feb 1997 04:46:49 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.8.5/8.7.2) with SMTP id EAA22936; Thu, 20 Feb 1997 04:21:20 +0100 (MET)
Message-Id: <3.0.32.19970220042119.00bb2930@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Thu, 20 Feb 1997 04:21:21 +0100
To: Aaron Bornstein <aaronb@j51.com>
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: does this alias exist??
Cc: audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 01:21 PM 2/18/97 -0500, Aaron Bornstein wrote:
>
>
>On Tue, 18 Feb 1997, Eivind Eklund wrote:
>
>> Extra space.  In addition, this line of code is not in style with the rest
>> of the sourcefile (the rest don't use NULL).  I rewrote these 3 lines to
>> 
>> +       home = getenv("HOME");
>> +       if (home == 0)
>> +         return; 
>> +       sprintf(home1, "%.*s/Bstar", MAXPATHLEN - 7, home);
>> 
>> which follow the style of the source better.
>> 
>	Whether or not it follows the style of the source, comparing 
>pointers to 0 is Bad Form.

I disagree.  If some pointers are compared to NULL, it is even harder to
spot the nasty ones which are compared to 0.

For newly written code, I agree completely - I've never written a compare
of a pointer to 0 in my life.

Anyway; the code is committed now.



Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org

From eivind@dimaga.com  Thu Feb 20 21:58:00 1997
Return-Path: <eivind@dimaga.com>
Received: from who.cdrom.com (who.cdrom.com [204.216.27.3])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA06598
          for <audit-games@freebsd.org>; Thu, 20 Feb 1997 21:57:59 -0800 (PST)
Received: from nic.follonett.no (nic.follonett.no [194.198.43.10])
          by who.cdrom.com (8.7.5/8.6.11) with ESMTP id VAA27752
          for <audit-games@freebsd.org>; Thu, 20 Feb 1997 21:36:41 -0800 (PST)
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id GAA07095; Fri, 21 Feb 1997 06:35:14 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.8.5/8.7.2) with SMTP id GAA15340; Fri, 21 Feb 1997 06:36:27 +0100 (MET)
Message-Id: <3.0.32.19970221063628.00a1dcc0@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Fri, 21 Feb 1997 06:36:29 +0100
To: Aaron Bornstein <aaronb@j51.com>
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: does this alias exist??
Cc: audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 09:26 PM 2/15/97 -0500, Aaron Bornstein wrote:

This come a little (AKA very) late, but shouldn't this be

>+
>+       /* Try to open the file safely. */
>+       if ( (stat(home1, &sbuf)) < 0) {                
         if ( (lstat(homel, &sbuf)) < 0) {
>+               fd = open(home1, O_WRONLY|O_CREAT|O_EXCL);
>+               if (fd < 0) {
>+                       fprintf(stderr, "Can't create %s\n", home1);
>+                       return;
>+               }
>+       } else {
>+               if (sbuf.st_nlink > 1) {
                 if (sbuf.st_mode & S_IFLNK) {
>+                       fprintf(stderr, "No symlinks!\n");
>+                       return;
>+               }

to stop symlinks instead of hardlinks?



Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org

From eivind@dimaga.com  Sat Feb 22 19:46:10 1997
Return-Path: <eivind@dimaga.com>
Received: from nic.follonett.no (nic.follonett.no [194.198.43.10])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA13354
          for <audit-games@freebsd.org>; Sat, 22 Feb 1997 19:46:08 -0800 (PST)
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id EAA29399; Sun, 23 Feb 1997 04:44:39 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.8.5/8.7.2) with SMTP id EAA08015; Sun, 23 Feb 1997 04:41:21 +0100 (MET)
Message-Id: <3.0.32.19970223044121.00a95950@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Sun, 23 Feb 1997 04:41:23 +0100
To: xaa@stack.nl (Mark Huizer)
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: patches for cribbage
Cc: audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 12:13 PM 2/16/97 +0100, Mark Huizer wrote:
>Well... all I could come up with (I suppose Aaron will at least double
>them :-)

It is in.  I added a check on the return code of setuid().
Sorry for the delay.

Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org

From eivind@dimaga.com  Sat Feb 22 21:17:28 1997
Return-Path: <eivind@dimaga.com>
Received: from nic.follonett.no (nic.follonett.no [194.198.43.10])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA18498
          for <audit-games@freebsd.org>; Sat, 22 Feb 1997 21:17:24 -0800 (PST)
Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id GAA29789; Sun, 23 Feb 1997 06:15:54 +0100 (MET)
Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.8.5/8.7.2) with SMTP id GAA08587; Sun, 23 Feb 1997 06:05:41 +0100 (MET)
Message-Id: <3.0.32.19970223060541.00a90d30@dimaga.com>
X-Sender: eivind@dimaga.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Sun, 23 Feb 1997 06:05:42 +0100
To: Aaron Bornstein <aaronb@j51.com>
From: Eivind Eklund <eivind@dimaga.com>
Subject: Re: sail patch
Cc: audit-games@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 10:14 AM 2/16/97 -0500, Aaron Bornstein wrote:
>
>
>gets()!@
>GETS()!@
>
>--- sail/pl_main.c.orig Sun Feb 16 10:11:03 1997
>+++ sail/pl_main.c      Sun Feb 16 10:04:16 1997
>@@ -198,7 +198,7 @@
>        else {
>                (void) printf("Your name, Captain? ");
>                (void) fflush(stdout);
>-               (void) gets(captain);
>+               (void) fgets(captain, sizeof(captain), stdin);
>                if (!*captain)
>                        (void) strcpy(captain, "no name");
>        }

This one lacks termination on overflow - fgets() work somewhat like
strncpy().  Besides, a proper fix has been in everything since 2.1.5.  Are
you looking at pre-2.1.5 sources, or are the CVS repository somehow screwed
up?

>@@ -210,7 +210,7 @@
>                printf("\nInitial broadside %s (grape, chain, round,
double): ",
>                        n ? "right" : "left");
>                (void) fflush(stdout);
>-               (void) scanf("%s", buf);
>+               (void) fgets(buf, sizeof(buf), stdin);
>                switch (*buf) {
>                case 'g':
>                        load = L_GRAPE;

Nice one.  I've committed this as a scanf("%9s", buf) due to fgets() and
scanf() having different behaviour.  (scanf() looks for whitespace, not
return)



Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org

From xaa@alterego.stack.nl  Tue Feb 25 07:12:13 1997
Return-Path: <xaa@alterego.stack.nl>
Received: from alterego.stack.nl (xaa@alterego.stack.nl [131.155.141.160])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA26543
          for <audit-games@freebsd.org>; Tue, 25 Feb 1997 07:12:11 -0800 (PST)
Received: (from xaa@localhost)
	by alterego.stack.nl (8.8.5/8.8.5) id QAA04586;
	Tue, 25 Feb 1997 16:12:22 +0100 (MET)
Message-ID: <Mutt.19970225161222.xaa@alterego.stack.nl>
Date: Tue, 25 Feb 1997 16:12:22 +0100
From: xaa@stack.nl (Mark Huizer)
To: audit-games@freebsd.org
Subject: worms... 1 patch
X-Mailer: Mutt 0.58.1
Mime-Version: 1.0

As discussed on the audit list... a term capability thingie should be at
least 2048 :-)

SO for worms:

--- worms.c.orig	Tue Feb 25 16:08:19 1997
+++ worms.c	Tue Feb 25 16:11:03 1997
@@ -196,7 +196,7 @@
 	int CO, IN, LI, last, bottom, ch, length, number, trail, Wrap;
 	short **ref;
 	char *AL, *BC, *CM, *EI, *HO, *IC, *IM, *IP, *SR;
-	char *field, tcb[100], *mp;
+	char *field, tcb[2048], *mp;
 	long random();
 	struct sgttyb tt;
 	extern short ospeed;

 Greetings
 Mark
-------------------------------------------------------------------------
- Mark Huizer    -   xaa@stack.nl    - rcbamh@urc.tue.nl    		-
-------------------------------------------------------------------------
- A witty saying proves nothing, but saying something pointless 	-
- gets people's attention.						-
-------------------------------------------------------------------------

From xaa@alterego.stack.nl  Tue Feb 25 08:00:20 1997
Return-Path: <xaa@alterego.stack.nl>
Received: from alterego.stack.nl (xaa@alterego.stack.nl [131.155.141.160])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA28752
          for <audit-games@freebsd.org>; Tue, 25 Feb 1997 08:00:18 -0800 (PST)
Resent-From: xaa@alterego.stack.nl
Received: (from xaa@localhost)
	by alterego.stack.nl (8.8.5/8.8.5) id RAA07770
	for audit-games@freebsd.org; Tue, 25 Feb 1997 17:00:34 +0100 (MET)
Resent-Message-Id: <199702251600.RAA07770@alterego.stack.nl>
Message-ID: <Mutt.19970225165812.xaa@alterego.stack.nl>
Date: Tue, 25 Feb 1997 16:58:12 +0100
From: xaa@stack.nl (Mark Huizer)
To: audit_games@freebsd.org
Subject: tetris/scores.h ... break highscore file??
X-Mailer: Mutt 0.58.1
Mime-Version: 1.0
Resent-Date: Tue, 25 Feb 1997 17:00:33 +0100
Resent-To: audit-games@freebsd.org

Well... in scores.h the struct highscore shoud have a field
hs_name[MAXLOGNAME] instead of [20]... but that would break tetris high
score files all over the world... fix it or leave it???

Mark
-------------------------------------------------------------------------
- Mark Huizer    -   xaa@stack.nl    - rcbamh@urc.tue.nl    		-
-------------------------------------------------------------------------
- Always be sincere. Even when you don't mean it.			-
-------------------------------------------------------------------------

From mazal@netvision.net.il  Tue Sep  1 13:38:16 1998
Return-Path: <mazal@netvision.net.il>
Received: from P1 ([192.117.232.9])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA19317
          for <audit-games@freebsd.org>; Tue, 1 Sep 1998 13:37:56 -0700 (PDT)
          (envelope-from mazal@netvision.net.il)
From: mazal@netvision.net.il
Received: from default - 192.117.233.58 by isdn.net.il with Microsoft SMTPSVC;
	 Tue, 1 Sep 1998 23:22:37 +0300
Date: Tue, 01 Sep 1998 23:25:08 +0300
Sender: mazal@netvision.net.il
Subject: US$ 120.000.000 de Dolares
To: audit-games@freebsd.org
X-Mailer: <Mailcast, version 1.0>
Message-ID: <0a8533722200198P1@isdn.net.il>


Estimado navegante:

US$ 120.000.000 lo esperan en: 

http://209.75.79.87/mazal 

y un tentador regalo para el espiritu en: 

http://209.75.79.87/tierra 

Nunca su bolsillo y su espiritu estuvieron tan cerca de enriquecerse.  

Gracias por su atencion.- 

R.M. Srul 
Mazal Israel Ltd
mazal7@aquanet.co.il




From print2live@angelfire.com Sat Mar 20 19:03:32 1999
Delivered-To: audit-games@freebsd.org
Received: from server2525 (ip157.moorestown4.nj.pub-ip.psi.net [38.26.85.157])
	by hub.freebsd.org (Postfix) with SMTP id 805EB151C3
	for <audit-games@freebsd.org>; Sat, 20 Mar 1999 19:03:23 -0800 (PST)
	(envelope-from print2live@angelfire.com)
To: <audit-games@freebsd.org>
From: <print2live@angelfire.com>
Subject: AD:Family Reunion T Shirts & More
Date: Sat, 20 Mar 1999 18:28:13
Return-Path: <print2live@angelfire.com>
Message-Id: <19990321030324.805EB151C3@hub.freebsd.org>

Message sent by:  Kuppler Graphics, 32 West Main Street, Maple Shade, New Jersey, 08052,
1-800-810-4330.   This list will NOT be sold.  All addresses 
are automatically added to our remove list.

Hello.  My name is Bill from Kuppler Graphics.  We do screenprinting on T Shirts, Sweatshirts,
Jackets, Hats, Tote Bags and more!

Do you or someone you know have a Family Reunion coming up?  Kuppler Graphics would like to
provide you with some great looking T Shirts for your Reunion.

Kuppler Graphics can also provide you with custom T's and promotional items such as imprinted
magnets, keychains, pens, mugs, hats, etc. for your business or any fundraising activity
(church, school, business etc.) We also can provide you with quality embroidery. 

We are a family owned company with over 15 years of experience.  

All work is done at this location.  No middle man.  Our prices are great!

Click reply to email us or call 1-800-810-4330 for more info


Bill
Kuppler Graphics
 
 
 
 
 

From remailer@replay.com Sun Mar 28 16:58:30 1999
Return-Path: <remailer@replay.com>
Delivered-To: audit-games@freebsd.org
Received: from unknown (1Cust90.tnt3.atl2.da.uu.net [153.36.17.90])
	by hub.freebsd.org (Postfix) with SMTP
	id 4120115588; Sun, 28 Mar 1999 16:58:24 -0800 (PST)
	(envelope-from remailer@replay.com)
From: <remailer@replay.com>
Subject: toner sales advertising
Date: Mon, 29 Mar 1999 04:33:14
Message-Id: <19990329005825.4120115588@hub.freebsd.org>

BENCHMARK PRINT SUPPLY
LASER PRINTER CARTRIDGES JUST FOR YOU AS 
 WELL AS FAX AND COPIER TONER 
 
   CHECK OUT THESE NEW PRINT CARTRIDGE PRICES :
 

APPLE 
 
  LASER WRITER  PRO 600 OR 16/600         $69
  LASER WRITER SELECT 300,310.360         $64
  LASER WRITER 300, 320, 360              $54 
  LASER WRITER LS,NT,2NTX,2F,2G & 2SC     $54 
  LASER WRITER 12/640                     $79 

HEWLETT PACKARD 

  LASERJET  SERIES 2,3 & 3D               $49 
  LASERJET  SERIES  2P AND 3P             $54 
  LASERJET SERIES 3SI AND 4SI             $75 
  LASERJET  SERIES 4L AND 4P              $49 
  LASERJET SERIES 4, 4M, 5, 5M            $59 
  LASERJET SERIES 4000 HIGH YIELD         $99 
  LASERJET SERIES 4V                      $95 
  LASERJET SERIES 5SI , 8000              $95 
  LASERJET SERIES 5L AND 6L               $49 
  LASERJET SERIES 5P, 5MP, 6P, 6MP        $59 
  LASERJET SERIES 5000                    $89 

HP LASERFAX 

  LASERFAX 500, 700, FX1,                 $59 
  LASERFAX 5000, 7000, FX2,               $59 
  LASERFAX  FX3                           $69 
  LASERFAX  FX4                           $79 
 

LEXMARK 

  OPTRA  4019, 4029  HIGH YIELD          $135 
  OPTRA R, 4039, 4049 HIGH YIELD         $135 
  OPTRA S 4059 HIGH YIELD                $135 
  OPTRA E                                 $59 
  OPTRA  N                               $115 
 

EPSON 

  EPL-70000, 8000                        $105 
  EPL-1000, 1500                         $105 
 

CANON 

  LBP-430                                 $49 
  LBP-460, 465                            $59 
  LBP-8 II                                $54 
  LBP-LX                                  $54 
  LBP-MX                                  $95 
  LBP-AX                                  $49 
  LBP-EX                                  $59 
  LBP-SX                                  $49 
  LBP-BX                                  $95 
  LBP-PX                                  $49 
  LBP-WX                                  $95 
  LBP-VX                                  $59 
  CANON FAX L700 THRU L790 FX1            $59 
  CANONFAX L5000 L70000  FX2              $59 
 

CANON COPIERS 

  PC 20, 25 ETC....                       $89 
  PC 3, 6RE, 7, 11  (A30)                 $69 
  PC 320 THRU 700  (E40)                  $89 
 

NEC 

  SERIES 2 LASER MODEL 95                $105 
 
 
 
 


PLACE YOUR ORDER BY :

   PHONE   770-399-0953 
   FAX:    770-698-9700 
   E-MAIL: BENCHMARK1@USA.NET WITH SUBJECTLINE: ORDER 
   MAIL:   1091 REDSTONE LANE, ATLANTA GA 30338 

MAKE SURE YOU INCLUDE THE FOLLOWING INFORMATION IN YOUR ORDER: 

             1)  PHONE NUMBER 
             2)  COMPANY NAME 
             3)  SHIPPING ADDRESS 
             4)  YOUR NAME 
             5)  ITEMS NEEDED WITH QUANTITIES 
             6)  METHOD OF PAYMENT. (COD OR CREDIT CARD) 
             7)  CREDIT CARD NUMBER WITH EXPIRATION DATE 
 
WE SHIP UPS GROUND STANDARD. ADD $4.5 FOR SHIPPING AND HANDLING. 
FOR ORDER QUESTIONS CALL 770-399-0953 
FOR CUSTOMER SERVICE  770-399-5505 


FOR E-MAIL REMOVAL USE:    BENCHMARK2@USA.NET OR CALL 
770-399-5614







 
 
 
 
 
 
 
 
 
 
 
 

From workshop@npcollege-edu.net Sun Jul  4 16:01:37 1999
Return-Path: <workshop@npcollege-edu.net>
Delivered-To: audit-games@freebsd.org
Received: from npcollege-edu.net (mail.npcollege-edu.net [209.232.226.194])
	by hub.freebsd.org (Postfix) with SMTP
	id 8ACB115178; Sun,  4 Jul 1999 16:01:33 -0700 (PDT)
	(envelope-from workshop@npcollege-edu.net)
From: <workshop@npcollege-edu.net>
Subject: Re: Deleting Your Address.
Date: Sun, 4 Jul 1999 12:36:31
Message-Id: <643.186304.310169@npcollege-edu.net>


From:The SFSE(Scientific Facts Search Engine).

When you send an email to EDU,R&D,or Job 
sites,your email might be forwarded via the 
SFSE to find the info you are looking for. 

The NU(NewAmerica University)has received
a copy of your email,but the date is 
Feb/25/99.Do you still need this info?

To refresh your memory you can go again to 
the NU website and look for these topics:

"The Redeemat has solved all environmental 
problems"-"The 9% Producer Fee would eliminate 
crime & taxes within 3 years"-"The free NHRI
(National Health & Retirement Insurance")-
"The job guarantee system(JIC/Job Insurance 
Corporation)"and "The list of 22nd Centurys' 
products & businesses available right now".

Or,request for the records of the SFSE search 
by putting in the subject REQUESTING INFO and 
click REPLY.

Or,in the future send "REQUEST FOR SEARCH"
(on any topic) directly to SFSE, and they will 
do the search for you,put in the subject SFSE.

Or,please allow us to DELETE your address 
permanently by simply clicking REPLY.


B.Morrison
workshop@npcollege-edu.net


 
 
 
 
 
 
 
 

From searches@freeola.com Fri Oct 15 12:37:02 1999
Return-Path: <searches@freeola.com>
Delivered-To: audit-games@freebsd.org
Received: from mailhub5.libertysurf.fr (mailhub5.libertysurf.fr [195.154.209.25])
	by hub.freebsd.org (Postfix) with ESMTP
	id CF8B714D7F; Fri, 15 Oct 1999 12:36:52 -0700 (PDT)
	(envelope-from searches@freeola.com)
Received: from mail.libertysurf.fr (ppp170-toulon.libertysurf.fr [213.36.56.170])
	by mailhub5.libertysurf.fr (8.9.3/8.9.3) with SMTP id VAA20451;
	Fri, 15 Oct 1999 21:33:37 +0200 (CEST)
From: searches@freeola.com
Message-Id: <199910151933.VAA20451@mailhub5.libertysurf.fr>
To: Friend@public.com
Date: Fri, 15 Oct 99 20:52:42 EST
Subject: Your Web Page

Increase your Web Site visiblity !

Try out :

*** Proven Web Page Optimisation Software ***
>> Audited results 55% Number 1  90% top 5 <<

*** Macro Media Web Page Design Software ****
  >>> Make your Web Pages sparkle <<<<

**** Accept checks from your Web Site *****
 >>>> Improve your margins & Cashflow <<<<

 Go to :  http://www.freebizlinks.net


