From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 07:10:10 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79E4A106566B for ; Sun, 7 Oct 2012 07:10:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4D2398FC0A for ; Sun, 7 Oct 2012 07:10:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q977AAiX087376 for ; Sun, 7 Oct 2012 07:10:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q977AA7e087375; Sun, 7 Oct 2012 07:10:10 GMT (envelope-from gnats) Resent-Date: Sun, 7 Oct 2012 07:10:10 GMT Resent-Message-Id: <201210070710.q977AA7e087375@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 29D84106566B for ; Sun, 7 Oct 2012 07:01:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id EF9C38FC19 for ; Sun, 7 Oct 2012 07:01:07 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q97717m9033551 for ; Sun, 7 Oct 2012 07:01:07 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q977170a033550; Sun, 7 Oct 2012 07:01:07 GMT (envelope-from nobody) Message-Id: <201210070701.q977170a033550@red.freebsd.org> Date: Sun, 7 Oct 2012 07:01:07 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 07:10:10 -0000 >Number: 172440 >Category: misc >Synopsis: [patch] [build] fix broken CTFCONVERT_CMD call >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 07 07:10:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: >Organization: EMC Isilon >Environment: >Description: The MAKE_VERSION check is broken in bsd.own.mk and generates a lot of warnings when compiling CURRENT as CTFCONVERT_CMD evaluates to a NUL string. $ make -VMAKE_VERSION 9201120530 $ make -f /store/freebsd/atf-head/share/mk/bsd.own.mk COMPILER_FEATURES= -VCTFCONVERT_CMD $ uname -a FreeBSD bayonetta.local 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r240836M: Sat Sep 22 12:30:11 PDT 2012 gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA amd64 The attached patch does the right thing for <= 9.x versions of pmake, 10.x <= versions of pmake, and bmake (bmake doesn't care about NUL commands). $ FreeBSD bayonetta.local 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r240836M: Sat Sep 22 12:30:11 PDT 2012 gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA amd64 $ make -f share/mk/bsd.own.mk COMPILER_FEATURES= -VCTFCONVERT_CMD @: # uname -a FreeBSD fallout-freebsd-current.local 10.0-CURRENT FreeBSD 10.0-CURRENT #10: Sat Aug 4 12:02:44 PDT 2012 root@fallout-freebsd-current.local:/usr/obj/nfs/bayonetta/scratch/p4/user/gcooper/atf-head/src/sys/GENERIC i386 # `make -V.OBJDIR`/make -f ../../share/mk/bsd.own.mk -VCTFCONVERT_CMD # bmake -f ../../share/mk/bsd.own.mk -VCTFCONVERT_CMD # `make -V.OBJDIR`/make -VMAKE_VERSION 10201205300 >How-To-Repeat: Build something using bsd.prog.mk with -DWITHOUT_CTF defined using the 9.x version of pmake and 10.x copy of bsd.own.mk . >Fix: Patch attached with submission follows: Index: share/mk/bsd.own.mk =================================================================== --- share/mk/bsd.own.mk (revision 241309) +++ share/mk/bsd.own.mk (working copy) @@ -671,7 +672,8 @@ .if ${MK_CTF} != "no" CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} -.elif defined(MAKE_VERSION) && ${MAKE_VERSION} >= 5201111300 +.elif defined(WITH_BMAKE) || \ + (defined(MAKE_VERSION) && ${MAKE_VERSION} >= 10201205300) CTFCONVERT_CMD= .else CTFCONVERT_CMD= @: >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 08:48:41 2012 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BDFA8106564A; Sun, 7 Oct 2012 08:48:41 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 50E8E8FC0C; Sun, 7 Oct 2012 08:48:41 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id wc20so3876706obb.13 for ; Sun, 07 Oct 2012 01:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=KkYP3IQCMsEZLgrgIkH89/0ATS6sp1jkTYrriONTPcc=; b=UWxdq+EKHNELn40u4wCwvInx1IsR+SFQ+JtTOlpXw3QI23nHshAYN6n9lpaCC1QJEB H9KCpwgLmr7AQ0mtw2okNOKxTRccDEEkXco+Lle/b95/enqUvprNE/WJ6TfNJOgvFgBY Hz9OTN1U14C8jq4nSyVzxMXC4NRwlxiWreJuHnZE3WV0QXUREvpggLeQVabiOm2hzIV2 OVNyU50KG5Es16a3gw/vPIUy4TMCCX/SHiNRQzuOpZMWT+WBI2o4Cpq/5uKCUe8YxY68 iqjlDLvIXaHLUiDUq4a+V+zaTo0ooP6IEP9TgSfwIwGd9GjdqDYrxpye6upqjatrJND7 eudw== MIME-Version: 1.0 Received: by 10.60.170.241 with SMTP id ap17mr10940897oec.4.1349599715141; Sun, 07 Oct 2012 01:48:35 -0700 (PDT) Received: by 10.76.142.201 with HTTP; Sun, 7 Oct 2012 01:48:35 -0700 (PDT) In-Reply-To: <201210070710.q977A9p8087371@freefall.freebsd.org> References: <201210070701.q977170a033550@red.freebsd.org> <201210070710.q977A9p8087371@freefall.freebsd.org> Date: Sun, 7 Oct 2012 01:48:35 -0700 Message-ID: From: Garrett Cooper To: freebsd-bugs@freebsd.org Content-Type: multipart/mixed; boundary=bcaec54d42949c28ee04cb742b92 Cc: Max Khon , Marcel Moolenaar , "Simon J. Gerraty" Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 08:48:41 -0000 --bcaec54d42949c28ee04cb742b92 Content-Type: text/plain; charset=ISO-8859-1 Correction -- bmake hates empty strings for commands too... bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c sha1hl.c -o sha1hl.o bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c /usr/src/lib/libmd/sha256c.c -o sha256c.o bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c sha256hl.c -o sha256hl.o bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c /usr/src/lib/libmd/sha512c.c -o sha512c.o bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c sha512hl.c -o sha512hl.o bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -DELF -Wa,--noexecstack -c /usr/src/lib/libmd/i386/sha.S bmake: ${CTFCONVERT_CMD} expands to empty string cc -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -DELF -Wa,--noexecstack -c /usr/src/lib/libmd/i386/rmd160.S bmake: ${CTFCONVERT_CMD} expands to empty string building static md library ranlib libmd.a cc -pg -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c /usr/src/lib/libmd/md4c.c -o md4c.po bmake: ${CTFCONVERT_CMD} expands to empty string cc -pg -O2 -pipe -DMALLOC_PRODUCTION -march=prescott -I/usr/src/lib/libmd -DSHA1_ASM -DRMD160_ASM -std=gnu99 -fstack-protector -Wno-pointer-sign -c /usr/src/lib/libmd/md5c.c -o md5c.po bmake: ${CTFCONVERT_CMD} expands to empty string The attached patch is correct per bmake today (if empty strings in bmake should be supported, a similar shim will need to be added for it as was added for pmake with r228157), and it seems to be accepted (or at least not explicitly denied) per POSIX (http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html): The algorithm for determining a new entry for target rules is partially unspecified. Some historical makes allow blank, empty, or comment lines within the collection of commands marked by leading s. A conforming makefile must ensure that each command starts with a , but implementations are free to ignore blank, empty, and comment lines without triggering the start of a new entry.s FWIW, the logic in this block was broken in r236338 by moving away from 5${DATE} to a ${RELENG_MAJOR_VERSION}${DATE} format. It's unfortunate that the new versioning scheme messed this up, but I understand the logic behind the new format as a good chunk of features committed to 10.x's version of pmake haven't been backported to stable/9 or earlier as it would potentially break things and one would need to do this in order to bootstrap make only when needed. I've CCed interested parties for the empty command enhancement in bmake as bmake has upstream sources and as such we shouldn't be changing things arbitrarily without talking with Simon first. Thanks! -Garrett --bcaec54d42949c28ee04cb742b92 Content-Type: text/plain; charset=US-ASCII; name="fix-MAKE_VERSION-nul-CTFCONVERT_CMD-check.patch.txt" Content-Disposition: attachment; filename="fix-MAKE_VERSION-nul-CTFCONVERT_CMD-check.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h7zua72r1 SW5kZXg6IHNoYXJlL21rL2JzZC5vd24ubWsKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2hhcmUvbWsvYnNkLm93 bi5tawkocmV2aXNpb24gMjQxMzA5KQorKysgc2hhcmUvbWsvYnNkLm93bi5tawkod29ya2luZyBj b3B5KQpAQCAtNjcxLDcgKzY3Miw4IEBACiAKIC5pZiAke01LX0NURn0gIT0gIm5vIgogQ1RGQ09O VkVSVF9DTUQ9CSR7Q1RGQ09OVkVSVH0gJHtDVEZGTEFHU30gJHsuVEFSR0VUfQotLmVsaWYgZGVm aW5lZChNQUtFX1ZFUlNJT04pICYmICR7TUFLRV9WRVJTSU9OfSA+PSA1MjAxMTExMzAwCisuZWxp ZiAhZGVmaW5lZChXSVRIX0JNQUtFKSAmJiBcCisgICAgICAoZGVmaW5lZChNQUtFX1ZFUlNJT04p ICYmICR7TUFLRV9WRVJTSU9OfSA+PSAxMDIwMTIwNTMwMCkKIENURkNPTlZFUlRfQ01EPQogLmVs c2UKIENURkNPTlZFUlRfQ01EPQlAOgo= --bcaec54d42949c28ee04cb742b92-- From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 10:40:56 2012 Return-Path: Delivered-To: bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 818B3106566C; Sun, 7 Oct 2012 10:40:56 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe09.c2i.net [212.247.155.2]) by mx1.freebsd.org (Postfix) with ESMTP id 864688FC08; Sun, 7 Oct 2012 10:40:54 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED Received: from [176.74.213.204] (account mc467741@c2i.net HELO laptop015.hselasky.homeunix.org) by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 154285814; Sun, 07 Oct 2012 12:40:46 +0200 From: Hans Petter Selasky To: freebsd-usb@freebsd.org, hackers@freebsd.org Date: Sun, 7 Oct 2012 12:42:11 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; ) References: <5070C1E9.5000405@sbcglobal.net> In-Reply-To: <5070C1E9.5000405@sbcglobal.net> X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp |U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI -%GU9V5]iUZF&nRn9mJ'?&>O MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201210071242.11932.hselasky@c2i.net> Cc: bugs@freebsd.org, Jin Guojun , current@freebsd.org Subject: Re: 9.1-RCs issues X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 10:40:56 -0000 On Sunday 07 October 2012 01:42:33 Jin Guojun wrote: > 1) moused stops functioning on 9.1-RC2. Neither PS2 nor USB mouse can work. > 9.1-RC1 has no such problem. > > 2) All i386 / amd64 of 9.1-RC1/RC2 have USB read failure -- see dmesg > output at end of this email. > ada0 is internal SATA drive for system disk -- s# partitions: /, /tmp, > /var, /usr > s1 -- 6.4-Release > s2 -- 8.3-Release > s3 -- 9.1-RC2 amd64 > s4 -- 9.1-RC2 i386 -- This slice also contains /home > da0 is external USB2 drive (300GB) plugged in USB2 port -- mounted on /mnt > Regarding USB, it might be some patches did not reach it for the RC's. Have you tried 9-stable, or any 10-current snapshots? --HPS From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 12:20:11 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9434F106566B for ; Sun, 7 Oct 2012 12:20:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7E3F98FC0A for ; Sun, 7 Oct 2012 12:20:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97CKBiN042000 for ; Sun, 7 Oct 2012 12:20:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97CKBT6041999; Sun, 7 Oct 2012 12:20:11 GMT (envelope-from gnats) Date: Sun, 7 Oct 2012 12:20:11 GMT Message-Id: <201210071220.q97CKBT6041999@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: misc/172413: Boot "loader" should accept additional parameters X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 12:20:11 -0000 The following reply was made to PR misc/172413; it has been noted by GNATS. From: "Andrey V. Elsukov" To: Zbigniew Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: misc/172413: Boot "loader" should accept additional parameters Date: Sun, 07 Oct 2012 16:18:49 +0400 On 07.10.2012 01:41, Zbigniew wrote: > Installed recently FreeBSD 9.0 - and I've got a problem: while > booting, "loader" somehow gets incorrect currdevice value, stopping > boot process. It does get "disk1s6a", but it should be "disk1s7a" > ("lsdev" reports such number). I can boot system, when I set currdev > "manually", then type "boot". Of course, loader won't read its config > files, when not having access to root directory. Having multiple > OS-es on HDD, I'm using GRUB for booting. My FreeBSD section looks > like: Hi, it seems your problem is similar to one described in the http://www.freebsd.org/cgi/query-pr.cgi?pr=158358 Can you try the loader(8) binary from the FreeBSD 10.0-CURRENT? You can get it from a snapshot: https://pub.allbsd.org/FreeBSD-snapshots/ -- WBR, Andrey V. Elsukov From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 12:43:38 2012 Return-Path: Delivered-To: bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F27161065670; Sun, 7 Oct 2012 12:43:37 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id 742E38FC12; Sun, 7 Oct 2012 12:43:35 +0000 (UTC) X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED, BAYES_50 Received: from [176.74.213.204] (account mc467741@c2i.net HELO laptop015.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 329237632; Sun, 07 Oct 2012 14:43:27 +0200 From: Hans Petter Selasky To: freebsd-hackers@freebsd.org Date: Sun, 7 Oct 2012 14:44:52 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; ) References: <5070C1E9.5000405@sbcglobal.net> <201210071242.11932.hselasky@c2i.net> In-Reply-To: <201210071242.11932.hselasky@c2i.net> X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp |U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI -%GU9V5]iUZF&nRn9mJ'?&>O MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201210071444.52845.hselasky@c2i.net> Cc: bugs@freebsd.org, hackers@freebsd.org, Jin Guojun , freebsd-usb@freebsd.org, current@freebsd.org Subject: Re: 9.1-RCs issues X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 12:43:38 -0000 On Sunday 07 October 2012 12:42:11 Hans Petter Selasky wrote: > On Sunday 07 October 2012 01:42:33 Jin Guojun wrote: > > 1) moused stops functioning on 9.1-RC2. Neither PS2 nor USB mouse can > > work. > > > > 9.1-RC1 has no such problem. > > > > 2) All i386 / amd64 of 9.1-RC1/RC2 have USB read failure -- see dmesg > > output at end of this email. > > ada0 is internal SATA drive for system disk -- s# partitions: /, /tmp, > > /var, /usr > > > > s1 -- 6.4-Release > > s2 -- 8.3-Release > > s3 -- 9.1-RC2 amd64 > > s4 -- 9.1-RC2 i386 -- This slice also contains /home > > > > da0 is external USB2 drive (300GB) plugged in USB2 port -- mounted on > > /mnt > > Regarding USB, it might be some patches did not reach it for the RC's. Have > you tried 9-stable, or any 10-current snapshots? > > --HPS s/reach/make --HPS From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 13:00:26 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4A0C2106564A for ; Sun, 7 Oct 2012 13:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 347BE8FC0A for ; Sun, 7 Oct 2012 13:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97D0Q0g045736 for ; Sun, 7 Oct 2012 13:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97D0QQJ045729; Sun, 7 Oct 2012 13:00:26 GMT (envelope-from gnats) Date: Sun, 7 Oct 2012 13:00:26 GMT Message-Id: <201210071300.q97D0QQJ045729@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Zbigniew Cc: Subject: Re: misc/172413: Boot "loader" should accept additional parameters X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Zbigniew List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 13:00:26 -0000 The following reply was made to PR misc/172413; it has been noted by GNATS. From: Zbigniew To: "Andrey V. Elsukov" Cc: freebsd-gnats-submit@freebsd.org Subject: Re: misc/172413: Boot "loader" should accept additional parameters Date: Sun, 7 Oct 2012 12:57:53 +0000 2012/10/7, Andrey V. Elsukov : > it seems your problem is similar to one described in the > http://www.freebsd.org/cgi/query-pr.cgi?pr=158358 > > Can you try the loader(8) binary from the FreeBSD 10.0-CURRENT? > You can get it from a snapshot: > https://pub.allbsd.org/FreeBSD-snapshots/ Thanks, it seems so! Downloaded the binary package base.txz from https://pub.allbsd.org/FreeBSD-snapshots/i386-i386/10.0-HEAD-20121006-JPSNAP/ftp/base.txz - then extracted "loader", replaced with it the former one, and yes - the system can be booted quite normally, I can see the logo/menu etc. Nevertheless I suppose, that ability to add boot-time parameters would be helpful as "workaround" in such cases. -- regards, Zbigniew From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 13:20:12 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F4201065670 for ; Sun, 7 Oct 2012 13:20:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 54B988FC0A for ; Sun, 7 Oct 2012 13:20:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DKCYm048615 for ; Sun, 7 Oct 2012 13:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97DKCns048614; Sun, 7 Oct 2012 13:20:12 GMT (envelope-from gnats) Resent-Date: Sun, 7 Oct 2012 13:20:12 GMT Resent-Message-Id: <201210071320.q97DKCns048614@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D26C106566B for ; Sun, 7 Oct 2012 13:14:43 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 24CE48FC14 for ; Sun, 7 Oct 2012 13:14:43 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DEg8O063427 for ; Sun, 7 Oct 2012 13:14:42 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q97DEgaO063426; Sun, 7 Oct 2012 13:14:42 GMT (envelope-from nobody) Message-Id: <201210071314.q97DEgaO063426@red.freebsd.org> Date: Sun, 7 Oct 2012 13:14:42 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/172451: [fetch] Not properly following redirects; causes unnecessary manual intervention with ports installs, etc X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 13:20:12 -0000 >Number: 172451 >Category: bin >Synopsis: [fetch] Not properly following redirects; causes unnecessary manual intervention with ports installs, etc >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 07 13:20:11 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9.1-STABLE >Organization: EMC Isilon >Environment: >Description: I have a fair amount of issues with fetch/libfetch and HTTP redirects. Some servers do it properly, others don't. A busted example (one of samba.org's HTTP servers) is as follows: $ fetch -vv -AFpr http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [us1.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] ---> us1.samba.org:80 looking up us1.samba.org connecting to us1.samba.org:80 requesting http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >How-To-Repeat: fetch -AFpr http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >Fix: Patch attached with submission follows: Index: lib/libfetch/http.c =================================================================== --- lib/libfetch/http.c (revision 241309) +++ lib/libfetch/http.c (working copy) @@ -1524,8 +1526,7 @@ /* try the provided URL first */ url = URL; - /* if the A flag is set, we only get one try */ - n = noredirect ? 1 : MAX_REDIRECT; + n = MAX_REDIRECT; i = 0; e = HTTP_PROTOCOL_ERROR; @@ -1772,6 +1774,15 @@ case hdr_location: if (!HTTP_REDIRECT(conn->err)) break; + /* + * Don't redirect due to bad server + * paranoia. + */ + if (noredirect && + conn->err == HTTP_MOVED_TEMP) { + n = 1; + break; + } if (new) free(new); if (verbose) >Release-Note: >Audit-Trail: >Unformatted: >>> GET /samba/ftp/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: us1.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Connection: close >>> <<< HTTP/1.1 301 Moved Permanently <<< Date: Sun, 07 Oct 2012 11:14:28 GMT <<< Server: Apache <<< Location: http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz <<< Vary: Accept-Encoding 301 redirect to http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [www.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] <<< Content-Length: 331 <<< Connection: close content length: [331] <<< Content-Type: text/html; charset=iso-8859-1 <<< fetch: http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz: Moved Permanently A working example with samba.org (without the -A flag): $ fetch -vv -Fpr http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [us1.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] ---> us1.samba.org:80 looking up us1.samba.org connecting to us1.samba.org:80 requesting http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >>> GET /samba/ftp/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: us1.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Connection: close >>> <<< HTTP/1.1 301 Moved Permanently <<< Date: Sun, 07 Oct 2012 11:25:32 GMT <<< Server: Apache <<< Location: http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz <<< Vary: Accept-Encoding 301 redirect to http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [www.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] <<< Content-Length: 331 <<< Connection: close content length: [331] <<< Content-Type: text/html; charset=iso-8859-1 <<< ---> www.samba.org:80 looking up www.samba.org connecting to www.samba.org:80 requesting http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >>> GET /samba/ftp/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: www.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Connection: close >>> <<< HTTP/1.1 301 Moved Permanently <<< Date: Sun, 07 Oct 2012 11:25:32 GMT <<< Server: Apache <<< Location: http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz <<< Vary: Accept-Encoding 301 redirect to http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [ftp.samba.org] port: [0] document: [/pub/samba/stable/samba-3.6.8.tar.gz] <<< Content-Length: 327 <<< Connection: close content length: [327] <<< Content-Type: text/html; charset=iso-8859-1 <<< ---> ftp.samba.org:80 looking up ftp.samba.org connecting to ftp.samba.org:80 requesting http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz >>> GET /pub/samba/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: ftp.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Connection: close >>> <<< HTTP/1.1 200 OK <<< Date: Sun, 07 Oct 2012 11:25:32 GMT <<< Server: Apache <<< Last-Modified: Mon, 17 Sep 2012 07:13:13 GMT <<< ETag: "125001d-207e10e-4c9e081b7b440" last modified: [2012-09-17 07:13:13] <<< Accept-Ranges: bytes <<< Content-Length: 34070798 <<< Connection: close content length: [34070798] <<< Content-Type: application/x-gzip <<< Content-Encoding: x-gzip <<< offset 0, length -1, size -1, clength 34070798 remote size / mtime: 34070798 / 1347865993 samba-3.6.8.tar.gz 2% of 32 MB 659 kBps^C fetch: transfer interrupted I think that the issue is that HTTP 3XX codes are blacklisted with the -A flag too liberally -- in particular 301, 302, and 307 should be followed per RFC-2616 [1]. The attached patch does that exactly (and also adds support for HTTP error code 305 -- us e proxy -- although scrubbing that before commit is fine if it should be in another bug). FWIW that's what the documentation for fetch(1) suggests as well... -A Do not automatically follow ``temporary'' (302) redirects. Some broken Web sites will return a redirect instead of a not-found error when the requested object does not exist. fetch(3) doesn't have anything to say on the matter (and in fact doesn't document all of the supported flags)... HTTP SCHEME The fetchXGetHTTP(), fetchGetHTTP() and fetchPutHTTP() functions imple- ment the HTTP/1.1 protocol. With a little luck, there is even a chance that they comply with RFC2616 and RFC2617. If the `d' (direct) flag is specified, fetchXGetHTTP(), fetchGetHTTP() and fetchPutHTTP() will use a direct connection even if a proxy server is defined. If the `i' (if-modified-since) flag is specified, and the ims_time field is set in struct url, then fetchXGetHTTP() and fetchGetHTTP() will send a conditional If-Modified-Since HTTP header to only fetch the content if it is newer than ims_time. Since there seems to be no good way of implementing the HTTP PUT method in a manner consistent with the rest of the fetch library, fetchPutHTTP() is currently unimplemented. After the patch is applied things function as I would expect: $ fetch -vv -AFpr http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [us1.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] ---> us1.samba.org:80 looking up us1.samba.org connecting to us1.samba.org:80 requesting http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >>> GET /samba/ftp/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: us1.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Range: bytes=827392- >>> Connection: close >>> <<< HTTP/1.1 301 Moved Permanently <<< Date: Sun, 07 Oct 2012 12:36:27 GMT <<< Server: Apache <<< Location: http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz <<< Vary: Accept-Encoding 301 redirect to http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [www.samba.org] port: [0] document: [/samba/ftp/stable/samba-3.6.8.tar.gz] <<< Content-Length: 331 <<< Connection: close content length: [331] <<< Content-Type: text/html; charset=iso-8859-1 <<< ---> www.samba.org:80 looking up www.samba.org connecting to www.samba.org:80 requesting http://www.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz >>> GET /samba/ftp/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: www.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Range: bytes=827392- >>> Connection: close >>> <<< HTTP/1.1 301 Moved Permanently <<< Date: Sun, 07 Oct 2012 12:36:28 GMT <<< Server: Apache <<< Location: http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz <<< Vary: Accept-Encoding 301 redirect to http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz scheme: [http] user: [] password: [] host: [ftp.samba.org] port: [0] document: [/pub/samba/stable/samba-3.6.8.tar.gz] <<< Content-Length: 327 <<< Connection: close content length: [327] <<< Content-Type: text/html; charset=iso-8859-1 <<< ---> ftp.samba.org:80 looking up ftp.samba.org connecting to ftp.samba.org:80 requesting http://ftp.samba.org/pub/samba/stable/samba-3.6.8.tar.gz >>> GET /pub/samba/stable/samba-3.6.8.tar.gz HTTP/1.1 >>> Host: ftp.samba.org >>> User-Agent: fetch libfetch/2.0 >>> Range: bytes=827392- >>> Connection: close >>> <<< HTTP/1.1 206 Partial Content <<< Date: Sun, 07 Oct 2012 12:36:28 GMT <<< Server: Apache <<< Last-Modified: Mon, 17 Sep 2012 07:13:13 GMT <<< ETag: "125001d-207e10e-4c9e081b7b440" last modified: [2012-09-17 07:13:13] <<< Accept-Ranges: bytes <<< Content-Length: 33243406 <<< Content-Range: bytes 827392-34070797/34070798 content length: [33243406] <<< Connection: close content range: [827392-34070797/34070798] <<< Content-Type: application/x-gzip <<< Content-Encoding: x-gzip <<< offset 827392, length 33243406, size 34070798, clength 33243406 local size / mtime: 827392 / 1347865993 remote size / mtime: 34070798 / 1347865993 samba-3.6.8.tar.gz 100% of 32 MB 2301 kBps 00m00s And removing the HTTP Error 302 clause I get behavior I would expect from fetch(1): $ fetch -AFpr http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz fetch: http://us1.samba.org/samba/ftp/stable/samba-3.6.8.tar.gz: Moved Permanently References: 1. http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 13:29:21 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0147A106564A; Sun, 7 Oct 2012 13:29:21 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C85DD8FC0C; Sun, 7 Oct 2012 13:29:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DTK1a049230; Sun, 7 Oct 2012 13:29:20 GMT (envelope-from eadler@freefall.freebsd.org) Received: (from eadler@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97DTK1t049226; Sun, 7 Oct 2012 13:29:20 GMT (envelope-from eadler) Date: Sun, 7 Oct 2012 13:29:20 GMT Message-Id: <201210071329.q97DTK1t049226@freefall.freebsd.org> To: eadler@FreeBSD.org, freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org From: eadler@FreeBSD.org Cc: Subject: Re: bin/172451: [fetch] Not properly following redirects; causes unnecessary manual intervention with ports installs, etc X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 13:29:21 -0000 Synopsis: [fetch] Not properly following redirects; causes unnecessary manual intervention with ports installs, etc Responsible-Changed-From-To: freebsd-bugs->eadler Responsible-Changed-By: eadler Responsible-Changed-When: Sun Oct 7 13:29:20 UTC 2012 Responsible-Changed-Why: I'll take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=172451 From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 13:40:14 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4DA7D1065674 for ; Sun, 7 Oct 2012 13:40:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 25FD48FC16 for ; Sun, 7 Oct 2012 13:40:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DeEME052275 for ; Sun, 7 Oct 2012 13:40:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97DeErw052274; Sun, 7 Oct 2012 13:40:14 GMT (envelope-from gnats) Resent-Date: Sun, 7 Oct 2012 13:40:14 GMT Resent-Message-Id: <201210071340.q97DeErw052274@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1003B1065670 for ; Sun, 7 Oct 2012 13:31:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id D57098FC1D for ; Sun, 7 Oct 2012 13:31:27 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DVRV3031867 for ; Sun, 7 Oct 2012 13:31:27 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q97DVR40031866; Sun, 7 Oct 2012 13:31:27 GMT (envelope-from nobody) Message-Id: <201210071331.q97DVR40031866@red.freebsd.org> Date: Sun, 7 Oct 2012 13:31:27 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/172452: [patch] [fetch] add HTTP 305 handling to libfetch X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 13:40:14 -0000 >Number: 172452 >Category: bin >Synopsis: [patch] [fetch] add HTTP 305 handling to libfetch >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 07 13:40:13 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9.1-STABLE >Organization: EMC Isilon >Environment: FreeBSD bayonetta.local 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r240836M: Sat Sep 22 12:30:11 PDT 2012 gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA amd64 >Description: While poking around RFC-2616 and looking at libfetch for bin/172451, I noticed that libfetch wasn't handling HTTP 305 style redirects. From the RFC... 10.3.6 305 Use Proxy The requested resource MUST be accessed through the proxy given by the Location field. The Location field gives the URI of the proxy. The recipient is expected to repeat this single request via the proxy. 305 responses MUST only be generated by origin servers. Note: RFC 2068 was not clear that 305 was intended to redirect a single request, and to be generated by origin servers only. Not observing these limitations has significant security consequences. Plugging in the support was relatively trivial, but my patch isn't ultra paranoid like noted here. I poked around curl and wget, and discovered that curl implements the support, but they don't do the "paranoia checking" and instead just redirect and wget doesn't implement it at all. Whether or not it's useful to implement this is a good question, but the simple patch is available for any interested parties. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: lib/libfetch/http.c =================================================================== --- lib/libfetch/http.c (revision 241309) +++ lib/libfetch/http.c (working copy) @@ -103,6 +103,7 @@ #define HTTP_MOVED_TEMP 302 #define HTTP_SEE_OTHER 303 #define HTTP_NOT_MODIFIED 304 +#define HTTP_USE_PROXY 305 #define HTTP_TEMP_REDIRECT 307 #define HTTP_NEED_AUTH 401 #define HTTP_NEED_PROXY_AUTH 407 @@ -112,7 +113,8 @@ #define HTTP_REDIRECT(xyz) ((xyz) == HTTP_MOVED_PERM \ || (xyz) == HTTP_MOVED_TEMP \ || (xyz) == HTTP_TEMP_REDIRECT \ - || (xyz) == HTTP_SEE_OTHER) + || (xyz) == HTTP_SEE_OTHER \ + || (xyz) == HTTP_USE_PROXY) #define HTTP_ERROR(xyz) ((xyz) > 400 && (xyz) < 599) @@ -1697,6 +1698,7 @@ case HTTP_MOVED_PERM: case HTTP_MOVED_TEMP: case HTTP_SEE_OTHER: + case HTTP_USE_PROXY: /* * Not so fine, but we still have to read the * headers to get the new location. >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 13:46:41 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DE6D91065670; Sun, 7 Oct 2012 13:46:41 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B11628FC0C; Sun, 7 Oct 2012 13:46:41 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q97DkfVZ052660; Sun, 7 Oct 2012 13:46:41 GMT (envelope-from eadler@freefall.freebsd.org) Received: (from eadler@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q97DkfMn052656; Sun, 7 Oct 2012 13:46:41 GMT (envelope-from eadler) Date: Sun, 7 Oct 2012 13:46:41 GMT Message-Id: <201210071346.q97DkfMn052656@freefall.freebsd.org> To: eadler@FreeBSD.org, freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org From: eadler@FreeBSD.org Cc: Subject: Re: bin/172452: [patch] [fetch] add HTTP 305 handling to libfetch X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 13:46:42 -0000 Synopsis: [patch] [fetch] add HTTP 305 handling to libfetch Responsible-Changed-From-To: freebsd-bugs->eadler Responsible-Changed-By: eadler Responsible-Changed-When: Sun Oct 7 13:46:41 UTC 2012 Responsible-Changed-Why: I'll take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=172452 From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 16:14:20 2012 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CAF15106566B; Sun, 7 Oct 2012 16:14:20 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 672628FC0A; Sun, 7 Oct 2012 16:14:20 +0000 (UTC) Received: from sa-nc-cs-116.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q97GEIRG060706 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 7 Oct 2012 09:14:19 -0700 (PDT) (envelope-from marcel@xcllnt.net) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) From: Marcel Moolenaar In-Reply-To: Date: Sun, 7 Oct 2012 09:14:13 -0700 Content-Transfer-Encoding: 7bit Message-Id: References: <201210070701.q977170a033550@red.freebsd.org> <201210070710.q977A9p8087371@freefall.freebsd.org> To: Garrett Cooper X-Mailer: Apple Mail (2.1499) Cc: Max Khon , freebsd-bugs@freebsd.org, Marcel Moolenaar , "Simon J. Gerraty" Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 16:14:20 -0000 On Oct 7, 2012, at 1:48 AM, Garrett Cooper wrote: > Please don't use WITH_BMAKE. It's only added for handling the switch. The option will be removed soon. BTW: Isn't it easier to introduce a CC_CMD variable that contains at least the compile command and to which you can append any commands you want? Not only does that eliminate the problem at hand, it also makes the whole think a lot less like a one-off hack, and more like a fundamental feature. Other things we may want to do after we compile a file is generate API/ABI information that we can validate so that we can fail the build when some code change breaks the ABI or API. Thoughts? -- Marcel Moolenaar marcel@xcllnt.net From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 16:31:10 2012 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 64FE7106566B for ; Sun, 7 Oct 2012 16:31:10 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2C5358FC12 for ; Sun, 7 Oct 2012 16:31:09 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi1so3649257pad.13 for ; Sun, 07 Oct 2012 09:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Q2ZHvmurmUGK8XON32/1k5w8r1a8a42+NL4Kw54hlho=; b=MO8Ct4JaCsQ/bKBI/HIogylL1wL+8zf4iwyjztAV/n2U9aLJL8JXcA8W94R3cTR6n2 IdyQCPEUli5RkADYEo5++D4yCiWlUef41XKFLgv1wYihuS7HO8ddAJKE3QXPzTGTts/2 zqBtZ4/UFr5HuF+6KfMIrZSenotLNhVe/9jLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=Q2ZHvmurmUGK8XON32/1k5w8r1a8a42+NL4Kw54hlho=; b=aOHWulCBCUvM8u5FkaIYYZEsJLja7QaSfWPGMS+gFtTwPhrc29MvWWWDytU68erWQD FSP2GrSd9EAEhy/8hxYPpc/EaYOapFN/ZJGhl7Exc0CpA+0kCFCNhQ8I0aW0Zb8jUNt3 /ces6RQFp5nCoYL834LvT+L8B9uK/jUsGxmow4t10vaw4FnsHlezpSygbQHkHNb0IDOG Zpkb3t2+pezQPJAzm6FjwFSsbOw0weibiJs/2QAW0GHAuFhVSqSP6U8m3RpIb7avPx8U DEjntB97KeoB5ThM5yWfFgA94jzrdUDfo5rtBZbDIIQRJ5Jb6RAVPpy3n0o6tiBT0M5J ApDg== Received: by 10.68.129.72 with SMTP id nu8mr46376135pbb.29.1349627469713; Sun, 07 Oct 2012 09:31:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.161.163 with HTTP; Sun, 7 Oct 2012 09:30:39 -0700 (PDT) In-Reply-To: References: <201210070701.q977170a033550@red.freebsd.org> <201210070710.q977A9p8087371@freefall.freebsd.org> From: Eitan Adler Date: Sun, 7 Oct 2012 12:30:39 -0400 Message-ID: To: Marcel Moolenaar Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnXcQBoyebfGm6CCGqxkdoJzaAYB8Q0uKQa2rgluldmex11BUBEXbFKy4rGb9RVGe6fmN4X Cc: Garrett Cooper , Max Khon , freebsd-bugs@freebsd.org, Marcel Moolenaar , "Simon J. Gerraty" Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 16:31:10 -0000 On 7 October 2012 12:14, Marcel Moolenaar wrote: > Other things we may want to do after we compile a file is > generate API/ABI information that we can validate so that > we can fail the build when some code change breaks the ABI > or API. +1. I would love generate-abi/generate-api and check-abi/check-api targets. -- Eitan Adler From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 18:39:18 2012 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D8F3A106567A; Sun, 7 Oct 2012 18:39:18 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from exprod7og104.obsmtp.com (exprod7og104.obsmtp.com [64.18.2.161]) by mx1.freebsd.org (Postfix) with ESMTP id 178768FC12; Sun, 7 Oct 2012 18:39:16 +0000 (UTC) Received: from P-EMHUB03-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob104.postini.com ([64.18.6.12]) with SMTP ID DSNKUHHMVFVfGMa6IbLxSnA1xTBsWlRHMsLK@postini.com; Sun, 07 Oct 2012 11:39:18 PDT Received: from magenta.juniper.net (172.17.27.123) by P-EMHUB03-HQ.jnpr.net (172.24.192.33) with Microsoft SMTP Server (TLS) id 8.3.213.0; Sun, 7 Oct 2012 11:38:11 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id q97IcAh49224; Sun, 7 Oct 2012 11:38:10 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 9ABF858094; Sun, 7 Oct 2012 11:38:10 -0700 (PDT) To: Garrett Cooper In-Reply-To: References: <201210070701.q977170a033550@red.freebsd.org> <201210070710.q977A9p8087371@freefall.freebsd.org> Comments: In-reply-to: Garrett Cooper message dated "Sun, 07 Oct 2012 01:48:35 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Sun, 7 Oct 2012 11:38:10 -0700 Message-ID: <20121007183810.9ABF858094@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain Cc: Max Khon , freebsd-bugs@freebsd.org, Marcel Moolenaar , sjg@juniper.net Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 18:39:19 -0000 On Sun, 7 Oct 2012 01:48:35 -0700, Garrett Cooper writes: > Correction -- bmake hates empty strings for commands too... That's interesting. I thought I fixed that back in May.. Ok, that was something like @${EMPTY} This is a variant of the same thing - will fix - in make. In the meantime, your patch, don't use WITH_BMAKE or even MK_BMAKE as a descriminator. defined(.PARSEDIR) is a reliable means of distinguishing bmake from the older make. > I've CCed interested parties for the empty command enhancement in >bmake as bmake has upstream sources and as such we shouldn't be >changing things arbitrarily without talking with Simon first. Yes, thanks. Patch below should be sufficient. Oddly, I've done a number of recent buildworlds with bmake and WITH_CTF and the only issue I saw was: make: "/b/sjg/work/fbsd-head/src/share/mk/bsd.own.mk" line 490: WITH_CTF and WITHOUT_CTF can't both be set. Index: share/mk/bsd.own.mk =================================================================== --- share/mk/bsd.own.mk (revision 241871) +++ share/mk/bsd.own.mk (working copy) @@ -671,7 +665,8 @@ MK_${var}:= no .if ${MK_CTF} != "no" CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} -.elif defined(MAKE_VERSION) && ${MAKE_VERSION} >= 5201111300 +.elif !defined(.PARSEDIR) && \ + defined(MAKE_VERSION) && ${MAKE_VERSION} >= 5201111300 CTFCONVERT_CMD= .else CTFCONVERT_CMD= @: From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 7 20:16:18 2012 Return-Path: Delivered-To: bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68C5C106566B for ; Sun, 7 Oct 2012 20:16:18 +0000 (UTC) (envelope-from jguojun@sbcglobal.net) Received: from nm23-vm0.access.bullet.mail.sp2.yahoo.com (nm23-vm0.access.bullet.mail.sp2.yahoo.com [98.139.44.180]) by mx1.freebsd.org (Postfix) with SMTP id 392AA8FC08 for ; Sun, 7 Oct 2012 20:16:17 +0000 (UTC) Received: from [98.139.44.103] by nm23.access.bullet.mail.sp2.yahoo.com with NNFMP; 07 Oct 2012 20:13:44 -0000 Received: from [98.139.44.65] by tm8.access.bullet.mail.sp2.yahoo.com with NNFMP; 07 Oct 2012 20:13:44 -0000 Received: from [127.0.0.1] by omp1002.access.mail.sp2.yahoo.com with NNFMP; 07 Oct 2012 20:13:44 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 287939.91701.bm@omp1002.access.mail.sp2.yahoo.com Received: (qmail 99427 invoked by uid 60001); 7 Oct 2012 20:13:43 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sbcglobal.net; s=s1024; t=1349640823; bh=WWSxVkv+VQWpnig8tDbnbgdYcsWSyeJLv0TYq0Q++X8=; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=DWeNp4F8BAcLMtdf9+mFaRHuIePAYsSFnwesE/vMuUq1qYnQFuUnX5/gqjLickID9VIRr3c1aXsIfZpRYDQMGVfflNQa6T6jgGxTXXU5CssChdvdZ7Ny0lfAKIATpv1u0iQb1KnVlKdL3uIfLZ1zMkXK1Sey9ftAwj8a+Sk37J0= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=sbcglobal.net; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=C32d/3h/OCY3fBbzBqCJf5mF6o/dINqIhwK8piQ7nRDjxaEQ1BqIsUxEUqlFb0yNIG8dV4ukgeHAmbdR5XdWGjMTHaEsnWpl1lSZE1v2H3jVwoefzqE9QKyvpuh317W6he7JOzjwfDA87zkSYPZzOTF7/TiQTcNUxwVXwkbfAUg=; X-YMail-OSG: 8tFkmFUVM1mxx2jvRY8QigFD605.ba7Ny9vY0gR7dZFLEir azmSAdc2DMpaFcM_fSygaF001s9KXWacSjC.zq4Je69PgUucJ3.fGHy_CXUT 8I9KQUiWOYaikMceRyMUlXv0jJip.dy3_KhQjeHUiiFaB82_2jpDX1ztlq_H .EMa9DRGqjEZLAnFjjJTUK6HGR2rIBbB4oVqQHBYZMVbVAYvEscQgnAwFCqk mg2XY_0PWzH2KEIfhvUs3xvSdEEf2pGz.fDCEAYISLz11sowAfe4jmYciJ76 Eq_qeJzon_NIOIpt61Io_E6PFFNJLS8jErToz4.vGDBuGNOPZLdw7MiUHbuV Qh3NUnApaofK9w._3pIC_U0147yOmoU.WBXCDe06r8_QkMaMYI2O5SBqTHQQ Uvzr1HczOQcfjrXQPKEqnu21aglpBP9_ooVovyQ66wPCzWYUfE6lu2E9hfG8 w_T0N0Ovkz3TYQyWHeyNWECcLYaxY1KaqpsBgrrWxlz4xSZsuAwKiOfVgJwk - Received: from [75.37.1.111] by web180905.mail.ne1.yahoo.com via HTTP; Sun, 07 Oct 2012 13:13:43 PDT X-Mailer: YahooMailRC/708 YahooMailWebService/0.8.122.442 References: <5070C1E9.5000405@sbcglobal.net> <201210071242.11932.hselasky@c2i.net> Message-ID: <1349640823.75414.YahooMailRC@web180905.mail.ne1.yahoo.com> Date: Sun, 7 Oct 2012 13:13:43 -0700 (PDT) From: Jin Guojun To: Hans Petter Selasky , freebsd-usb@freebsd.org In-Reply-To: <201210071242.11932.hselasky@c2i.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: bugs@freebsd.org, stable@freebsd.org Subject: Re: 9.1-RCs issues X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 20:16:18 -0000 What 9-stable did you imply? 9.0-Release has the same problem at offset > 274GB. I could not find current snapshots, ftp.freebsd.org://pub/FreeBSD/snapshots is empty, and I cannot ftp to snapshots.jp.freebsd.org. ________________________________ From: Hans Petter Selasky To: freebsd-usb@freebsd.org; hackers@freebsd.org Cc: Jin Guojun ; bugs@freebsd.org; current@freebsd.org Sent: Sun, October 7, 2012 3:40:50 AM Subject: Re: 9.1-RCs issues On Sunday 07 October 2012 01:42:33 Jin Guojun wrote: > 1) moused stops functioning on 9.1-RC2. Neither PS2 nor USB mouse can work. > 9.1-RC1 has no such problem. > > 2) All i386 / amd64 of 9.1-RC1/RC2 have USB read failure -- see dmesg > output at end of this email. > ada0 is internal SATA drive for system disk -- s# partitions: /, /tmp, > /var, /usr > s1 -- 6.4-Release > s2 -- 8.3-Release > s3 -- 9.1-RC2 amd64 > s4 -- 9.1-RC2 i386 -- This slice also contains /home > da0 is external USB2 drive (300GB) plugged in USB2 port -- mounted on /mnt > Regarding USB, it might be some patches did not reach it for the RC's. Have you tried 9-stable, or any 10-current snapshots? --HPS