{
	"issue": {
		"url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
		"repository_url": "https://api.github.com/repos/laurent22/joplin",
		"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8890/labels{/name}",
		"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8890/comments",
		"events_url": "https://api.github.com/repos/laurent22/joplin/issues/8890/events",
		"html_url": "https://github.com/laurent22/joplin/pull/8890",
		"id": 1899393223,
		"node_id": "PR_kwDOBLftOs5afbWZ",
		"number": 8890,
		"title": "All: Resolves #8728: Bump mermaid version to 10.4.0 to support new chart types",
		"user": {
			"login": "oj-lappi",
			"id": 8479687,
			"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
			"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
			"gravatar_id": "",
			"url": "https://api.github.com/users/oj-lappi",
			"html_url": "https://github.com/oj-lappi",
			"followers_url": "https://api.github.com/users/oj-lappi/followers",
			"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
			"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
			"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
			"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
			"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
			"repos_url": "https://api.github.com/users/oj-lappi/repos",
			"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
			"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
			"type": "User",
			"user_view_type": "public",
			"site_admin": false
		},
		"labels": [],
		"state": "closed",
		"locked": false,
		"assignee": null,
		"assignees": [],
		"milestone": null,
		"comments": 15,
		"created_at": "2023-09-16T10:49:14Z",
		"updated_at": "2023-09-19T10:31:33Z",
		"closed_at": "2023-09-19T10:31:17Z",
		"author_association": "CONTRIBUTOR",
		"sub_issues_summary": {
			"total": 0,
			"completed": 0,
			"percent_completed": 0
		},
		"active_lock_reason": null,
		"draft": false,
		"pull_request": {
			"url": "https://api.github.com/repos/laurent22/joplin/pulls/8890",
			"html_url": "https://github.com/laurent22/joplin/pull/8890",
			"diff_url": "https://github.com/laurent22/joplin/pull/8890.diff",
			"patch_url": "https://github.com/laurent22/joplin/pull/8890.patch",
			"merged_at": "2023-09-19T10:31:17Z"
		},
		"body": " A bump from 9.2.2 to 10.4.0 adds at least the following chart types:\r\n - timeline chart\r\n - quadrant charts\r\n - Sankey diagrams (flow from one set of elements to another set, e.g. used in budget analysis)\r\n\r\nBrowsing through the forums I noticed some old topics on previous updates to the mermaid dependency. \r\n\r\nhttps://discourse.joplinapp.org/t/upgrading-mermaid/10140/8\r\n>laurent, Jun '21:\r\n>Normally it's easy and [even documented 30](https://github.com/laurent22/joplin/tree/dev/packages/renderer#updating-a-markdown-it-plugin) but I guess no-one took the time to do it. Often we only update when there's a bug or significant improvement in the library.\r\n\r\nI've tested, and bumping the version number gives us all the implemented chart types out of the box (which I think counts as a significant improvement).\r\n\r\nThis would of course be a major version bump, but I can't comment on the breaking changes for v10, it seems to work fine, but I don't have the perspective that regular contributors do. The breaking changes for mermaid v10 are listed here:\r\nhttps://github.com/mermaid-js/mermaid/blob/master/CHANGELOG.md#1000\r\n\r\nFixes #8728, #8701, #6769\r\n",
		"closed_by": {
			"login": "laurent22",
			"id": 1285584,
			"node_id": "MDQ6VXNlcjEyODU1ODQ=",
			"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
			"gravatar_id": "",
			"url": "https://api.github.com/users/laurent22",
			"html_url": "https://github.com/laurent22",
			"followers_url": "https://api.github.com/users/laurent22/followers",
			"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
			"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
			"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
			"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
			"organizations_url": "https://api.github.com/users/laurent22/orgs",
			"repos_url": "https://api.github.com/users/laurent22/repos",
			"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
			"received_events_url": "https://api.github.com/users/laurent22/received_events",
			"type": "User",
			"user_view_type": "public",
			"site_admin": false
		},
		"reactions": {
			"url": "https://api.github.com/repos/laurent22/joplin/issues/8890/reactions",
			"total_count": 2,
			"+1": 2,
			"-1": 0,
			"laugh": 0,
			"hooray": 0,
			"confused": 0,
			"heart": 0,
			"rocket": 0,
			"eyes": 0
		},
		"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8890/timeline",
		"performed_via_github_app": null,
		"state_reason": null
	},
	"comments": [
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722202414",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722202414",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722202414,
			"node_id": "IC_kwDOBLftOs5mprku",
			"user": {
				"login": "github-actions[bot]",
				"id": 41898282,
				"node_id": "MDM6Qm90NDE4OTgyODI=",
				"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/github-actions%5Bbot%5D",
				"html_url": "https://github.com/apps/github-actions",
				"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
				"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
				"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
				"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
				"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
				"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
				"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
				"type": "Bot",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T10:49:27Z",
			"updated_at": "2023-09-19T10:31:33Z",
			"author_association": "CONTRIBUTOR",
			"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA  ✍️ ✅",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722202414/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722202458",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722202458",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722202458,
			"node_id": "IC_kwDOBLftOs5mprla",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T10:49:44Z",
			"updated_at": "2023-09-16T10:49:44Z",
			"author_association": "CONTRIBUTOR",
			"body": "I have read the CLA Document and I hereby sign the CLA",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722202458/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722203703",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722203703",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722203703,
			"node_id": "IC_kwDOBLftOs5mpr43",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T10:55:48Z",
			"updated_at": "2023-09-16T10:55:48Z",
			"author_association": "CONTRIBUTOR",
			"body": "Related to #7629",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722203703/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722205350",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722205350",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722205350,
			"node_id": "IC_kwDOBLftOs5mpsSm",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T11:04:06Z",
			"updated_at": "2023-09-16T11:04:06Z",
			"author_association": "CONTRIBUTOR",
			"body": "Can confirm that mindmap charts work after this update as well.",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722205350/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722209076",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722209076",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722209076,
			"node_id": "IC_kwDOBLftOs5mptM0",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T11:25:05Z",
			"updated_at": "2023-09-16T11:25:16Z",
			"author_association": "CONTRIBUTOR",
			"body": "Fixes/resolves #8728, #8701, #6769",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722209076/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722232365",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722232365",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722232365,
			"node_id": "IC_kwDOBLftOs5mpy4t",
			"user": {
				"login": "wh201906",
				"id": 62299611,
				"node_id": "MDQ6VXNlcjYyMjk5NjEx",
				"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/wh201906",
				"html_url": "https://github.com/wh201906",
				"followers_url": "https://api.github.com/users/wh201906/followers",
				"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
				"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
				"organizations_url": "https://api.github.com/users/wh201906/orgs",
				"repos_url": "https://api.github.com/users/wh201906/repos",
				"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
				"received_events_url": "https://api.github.com/users/wh201906/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T13:38:02Z",
			"updated_at": "2023-09-16T13:38:02Z",
			"author_association": "CONTRIBUTOR",
			"body": "It seems the mermaid team has added the CJS support back, that's why bumping the version works\r\nhttps://github.com/mermaid-js/mermaid/commit/04305bdddcda6970301dd7961b1d0c31997132f1",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722232365/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722233298",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722233298",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722233298,
			"node_id": "IC_kwDOBLftOs5mpzHS",
			"user": {
				"login": "wh201906",
				"id": 62299611,
				"node_id": "MDQ6VXNlcjYyMjk5NjEx",
				"avatar_url": "https://avatars.githubusercontent.com/u/62299611?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/wh201906",
				"html_url": "https://github.com/wh201906",
				"followers_url": "https://api.github.com/users/wh201906/followers",
				"following_url": "https://api.github.com/users/wh201906/following{/other_user}",
				"gists_url": "https://api.github.com/users/wh201906/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/wh201906/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/wh201906/subscriptions",
				"organizations_url": "https://api.github.com/users/wh201906/orgs",
				"repos_url": "https://api.github.com/users/wh201906/repos",
				"events_url": "https://api.github.com/users/wh201906/events{/privacy}",
				"received_events_url": "https://api.github.com/users/wh201906/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T13:42:40Z",
			"updated_at": "2023-09-16T13:42:40Z",
			"author_association": "CONTRIBUTOR",
			"body": "@oj-lappi I found that @tessus changed more files than this PR when bumping the mermaid version. Would you please check the related files?\r\n#5831 #6039 #6849 #7330",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722233298/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722298450",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722298450",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722298450,
			"node_id": "IC_kwDOBLftOs5mqDBS",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T19:23:16Z",
			"updated_at": "2023-09-16T19:23:16Z",
			"author_association": "CONTRIBUTOR",
			"body": "Ah, I had missed the postinstall step. I'll update tomorrow. \n\nIs there a way to user test the mobile version on desktop btw? I've only tested the desktop app. ",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722298450/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722299674",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722299674",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722299674,
			"node_id": "IC_kwDOBLftOs5mqDUa",
			"user": {
				"login": "tessus",
				"id": 223439,
				"node_id": "MDQ6VXNlcjIyMzQzOQ==",
				"avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/tessus",
				"html_url": "https://github.com/tessus",
				"followers_url": "https://api.github.com/users/tessus/followers",
				"following_url": "https://api.github.com/users/tessus/following{/other_user}",
				"gists_url": "https://api.github.com/users/tessus/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/tessus/subscriptions",
				"organizations_url": "https://api.github.com/users/tessus/orgs",
				"repos_url": "https://api.github.com/users/tessus/repos",
				"events_url": "https://api.github.com/users/tessus/events{/privacy}",
				"received_events_url": "https://api.github.com/users/tessus/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T19:30:44Z",
			"updated_at": "2023-09-16T19:30:44Z",
			"author_association": "COLLABORATOR",
			"body": "> Is there a way to user test the mobile version on desktop btw? I've only tested the desktop app.\r\n\r\nYep, https://github.com/laurent22/joplin/blob/dev/BUILD.md#testing-the-mobile-application",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722299674/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722333341",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722333341",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722333341,
			"node_id": "IC_kwDOBLftOs5mqLid",
			"user": {
				"login": "jasonwilliams",
				"id": 936006,
				"node_id": "MDQ6VXNlcjkzNjAwNg==",
				"avatar_url": "https://avatars.githubusercontent.com/u/936006?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/jasonwilliams",
				"html_url": "https://github.com/jasonwilliams",
				"followers_url": "https://api.github.com/users/jasonwilliams/followers",
				"following_url": "https://api.github.com/users/jasonwilliams/following{/other_user}",
				"gists_url": "https://api.github.com/users/jasonwilliams/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/jasonwilliams/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/jasonwilliams/subscriptions",
				"organizations_url": "https://api.github.com/users/jasonwilliams/orgs",
				"repos_url": "https://api.github.com/users/jasonwilliams/repos",
				"events_url": "https://api.github.com/users/jasonwilliams/events{/privacy}",
				"received_events_url": "https://api.github.com/users/jasonwilliams/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-16T22:46:25Z",
			"updated_at": "2023-09-16T22:47:08Z",
			"author_association": "CONTRIBUTOR",
			"body": "Great work @oj-lappi \r\nDo you know if the update resolves any of the issues mentioned in the master issue?\r\n\r\nhttps://github.com/laurent22/joplin/issues/7629#issue-1535353471",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722333341/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722435188",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722435188",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722435188,
			"node_id": "IC_kwDOBLftOs5mqkZ0",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-17T09:28:16Z",
			"updated_at": "2023-09-17T09:28:16Z",
			"author_association": "CONTRIBUTOR",
			"body": "Just reran everything the way tessus outlined it, so now the mobile assets should all be there. I'll now try to test the mobile version, but I don't have the environment set up yet, so this may take a while.",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722435188/reactions",
				"total_count": 1,
				"+1": 1,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722444647",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722444647",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722444647,
			"node_id": "IC_kwDOBLftOs5mqmtn",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-17T10:20:48Z",
			"updated_at": "2023-09-17T11:19:06Z",
			"author_association": "CONTRIBUTOR",
			"body": "> Great work @oj-lappi Do you know if the update resolves any of the issues mentioned in the master issue?\r\n> \r\n> [#7629 (comment)](https://github.com/laurent22/joplin/issues/7629#issue-1535353471)\r\n\r\nYup, out of the documented issues, both are solved (#6769, #6711)\r\n\r\nOf the undocumented issues, the ones below with checked boxes are resolved afaict (tested on desktop):\r\n- [X] Mindmaps don't work\r\n- [X] tooltips don't work\r\n - tooltips give me the title of the charts. On 9.2.2 some charts, like the flowchart, didn't recognize titles, but titles as tooltips work even on 9.2.2 for me for e.g. the Gantt chart or Pie chart\r\n- [ ] fa icons\r\n - fa icons show up in the rich text editor, but not in the markdown editor. In the rich text editor, the width of the fa icon is not used to calculate the width of the box its in, leading to part of the text being clipped off\r\n- [ ] support dark mode\r\n - the images drawn by mermaid still appear with a white background",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722444647/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722562051",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722562051",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722562051,
			"node_id": "IC_kwDOBLftOs5mrDYD",
			"user": {
				"login": "oj-lappi",
				"id": 8479687,
				"node_id": "MDQ6VXNlcjg0Nzk2ODc=",
				"avatar_url": "https://avatars.githubusercontent.com/u/8479687?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/oj-lappi",
				"html_url": "https://github.com/oj-lappi",
				"followers_url": "https://api.github.com/users/oj-lappi/followers",
				"following_url": "https://api.github.com/users/oj-lappi/following{/other_user}",
				"gists_url": "https://api.github.com/users/oj-lappi/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/oj-lappi/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/oj-lappi/subscriptions",
				"organizations_url": "https://api.github.com/users/oj-lappi/orgs",
				"repos_url": "https://api.github.com/users/oj-lappi/repos",
				"events_url": "https://api.github.com/users/oj-lappi/events{/privacy}",
				"received_events_url": "https://api.github.com/users/oj-lappi/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-17T20:31:40Z",
			"updated_at": "2023-09-17T20:48:49Z",
			"author_association": "CONTRIBUTOR",
			"body": "Tested on a Pixel 7 AVD, all the charts tested render on android as well (timeline, mindmap, quadrant, Sankey). The font-awesome icons do not render on android, which makes sense since this was pretty much what I saw on desktop (fa icons only rendered in the rich text editor on desktop).\r\n\r\n![charts_0](https://github.com/laurent22/joplin/assets/8479687/e4dfc268-b5ed-41b1-a636-15e0b39c3932)\r\n\r\n\r\n![image](https://github.com/laurent22/joplin/assets/8479687/cc6b8fa6-c1ce-4973-8808-8e3b3d66ba7f)\r\n\r\n\r\nAfaict, everything seems to work just fine. \r\n\r\n\r\n\r\n",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722562051/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722581694",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1722581694",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1722581694,
			"node_id": "IC_kwDOBLftOs5mrIK-",
			"user": {
				"login": "jasonwilliams",
				"id": 936006,
				"node_id": "MDQ6VXNlcjkzNjAwNg==",
				"avatar_url": "https://avatars.githubusercontent.com/u/936006?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/jasonwilliams",
				"html_url": "https://github.com/jasonwilliams",
				"followers_url": "https://api.github.com/users/jasonwilliams/followers",
				"following_url": "https://api.github.com/users/jasonwilliams/following{/other_user}",
				"gists_url": "https://api.github.com/users/jasonwilliams/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/jasonwilliams/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/jasonwilliams/subscriptions",
				"organizations_url": "https://api.github.com/users/jasonwilliams/orgs",
				"repos_url": "https://api.github.com/users/jasonwilliams/repos",
				"events_url": "https://api.github.com/users/jasonwilliams/events{/privacy}",
				"received_events_url": "https://api.github.com/users/jasonwilliams/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-17T22:16:06Z",
			"updated_at": "2023-09-17T22:16:06Z",
			"author_association": "CONTRIBUTOR",
			"body": "I've tested these changes (on desktop), I can see the mermaid diagrams are still working. I can also see:\r\n- Mindmap\r\n- Timeline\r\n- Sankey\r\n- Quadrant\r\n\r\nall working fine.\r\n\r\nI can see https://github.com/laurent22/joplin/issues/6769 is fixed in this PR.\r\nI can also see https://github.com/laurent22/joplin/issues/6711 is fixed in this PR.\r\n\r\n@laurent22 you will nee to approve the workflow so it can run.\r\nI've approved these changes but @tessus may also want to look.",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1722581694/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		},
		{
			"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1725243844",
			"html_url": "https://github.com/laurent22/joplin/pull/8890#issuecomment-1725243844",
			"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8890",
			"id": 1725243844,
			"node_id": "IC_kwDOBLftOs5m1SHE",
			"user": {
				"login": "laurent22",
				"id": 1285584,
				"node_id": "MDQ6VXNlcjEyODU1ODQ=",
				"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/laurent22",
				"html_url": "https://github.com/laurent22",
				"followers_url": "https://api.github.com/users/laurent22/followers",
				"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
				"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
				"organizations_url": "https://api.github.com/users/laurent22/orgs",
				"repos_url": "https://api.github.com/users/laurent22/repos",
				"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
				"received_events_url": "https://api.github.com/users/laurent22/received_events",
				"type": "User",
				"user_view_type": "public",
				"site_admin": false
			},
			"created_at": "2023-09-19T10:31:10Z",
			"updated_at": "2023-09-19T10:31:10Z",
			"author_association": "OWNER",
			"body": "That's great, thanks guys for looking into this!",
			"reactions": {
				"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1725243844/reactions",
				"total_count": 0,
				"+1": 0,
				"-1": 0,
				"laugh": 0,
				"hooray": 0,
				"confused": 0,
				"heart": 0,
				"rocket": 0,
				"eyes": 0
			},
			"performed_via_github_app": null
		}
	]
}